Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
y/Yalready use for SHAs) and shows "Copied N lines".+/-markers, no hunk headers, no padding. Wrapped lines copy as one line and sideways-scrolled lines copy whole. In split view only the half the drag started on is copied.ycopies the selection (Files viewer with no selection: the whole file; diffs with no selection: thevrange, else the line under the cursor).Ycopies the file's path. In the Files treey/Ycopy the entry's relative/absolute path. History's commit and file lists keepy/Yfor the SHA.ysays to reveal it first (v).Y(the path) still works.Tests
cargo test --workspace(937 passed) and clippy are clean. New unit tests for the text extraction, render/mouse tests for drag, copy, Esc, gutter staging, split halves, wrapping, sideways scroll, double-click and masked secrets, and a keymap test. In a pty, real mouse drags sent to the release binary produced OSC 52 payloads whose decoded text was exactly the selected lines.Not verified
Kitty itself (that the payload reaches the macOS clipboard, and how the highlight looks), and behaviour inside herdr or tmux (tmux needs
set-clipboard on).