Closed
Conversation
…ault Add geocoding support for city name lookups (e.g. `weathr london`), city-specific ASCII art skylines for 8 major cities (London, New York, Paris, Tokyo, Sydney, Dubai, San Francisco, Rome) plus generic urban and rural fallbacks. Include --duration flag for timed exit, --install-shell/--uninstall-shell for shell startup integration, --set-default to save preferred location to config, and a location label display in the top-right corner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Quick Start section, city lookup docs, city skylines list, shell integration guide, --duration flag, geocoding privacy info, and updated table of contents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Prevents the location label from overlapping with the HUD text on narrow terminals by checking available width and dropping the label to line 2 when needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a couple of features that might be useful.
src/geocoding.rs — New module for city name geocoding via Open-Meteo API
src/scene/skyline/ — New skyline system with ASCII art for 8 cities + 2 generic fallbacks
src/scene/mod.rs — SceneMode enum (Town vs Skyline) with branching render
src/app.rs — Location label display, duration timeout, chimney smoke gating
src/main.rs — CLI args for city, --set-default, --duration, --install-shell, --uninstall-shell
src/config.rs — Serialize support, city/country fields, save() method
src/error.rs — GeocodingError enum with retry/network handling
src/lib.rs — Added geocoding module
src/weather/types.rs — Added Serialize derive