Repository navigation
test: classifier tests and CI workflow - #5
Merged
Merged
Conversation
15 Vitest tests for src/classify.ts covering: - Exact scheme: plain-tx sponsorship (regression test for original fee-bump-only bug), fee-bump path, self-sponsored non-settlement, wrong contract, wrong function, wrong arg count, failed status - Upto scheme: valid settlement, silent-close on missing event, wrong contract, wrong arg count - Edge cases: empty ops, non-invocation op, multi-op iteration, explicit fee-bump regression The fee-bump-only bug (v1 heuristic, caught during validation before shipping) would have silently missed all plain-tx-sponsored settlements including Vellar's own primary pattern. Test 1 and test 15 are explicit regression guards for that class of failure. .github/workflows/ci.yml: typecheck + test + build on push/PR to main. No live network calls in CI.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
15 Vitest tests for src/classify.ts — the only
code where silent failures have real consequences.
A wrong classifier produces false negatives with
no error, no log, no signal.
Coverage
fee-bump sponsor, self-sponsored rejection,
wrong contract, wrong function, wrong args,
failed status)
silent-close, wrong contract, wrong args)
multi-op, explicit fee-bump regression)
Regression guard
Test 1 and test 15 are explicit guards for the
original fee-bump-only bug — the v1 heuristic
that would have silently missed every
plain-tx-sponsored settlement including Vellar's
own primary pattern.
CI
.github/workflows/ci.yml runs typecheck + test +
build on every push and PR to main.