Repository navigation
fix(sync): renew sessions and preserve uploads through reauthentication - #45
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login expiration currently causes each sync entity to repeat the same error while automatic retries continue. This change checks and renews valid sessions through Better Auth, makes one recovery attempt after an authentication rejection, then pauses all sync channels and offers “Sign in again” without clearing local edits. Reauthentication with the same business account resumes pending uploads; mismatched or stale-account recovery results are rejected.
The API enables Better Auth bearer session handling so cookie-unavailable clients use the same expiry and renewal rules. Offline account hints remain offline rather than being classified as expired. RxDB, real-time notifications and symbolic synchronization share the pause; network failures retain retry behavior.
The Verify runner is pinned to Ubuntu 24.04, which the locked Playwright version supports; Ubuntu latest now selects 26.04 and cannot install Chromium dependencies. All browser checks remain enabled.
Validation:
Release from current main preserves the existing transactional sync state, account ownership, pending-write safety, cloud confirmation and policy consent behavior. The four theme-test failures from the older development workspace are fixed there; current main already contains their missing Labs fixture. Unrelated local work is excluded. Web and API deploy together through the existing production workflow; no desktop installer is included.