This repository was archived by the owner on May 19, 2024. It is now read-only.
#108 Blog owner can now enable or disable comments for blog post - #148
Open
manojkulkarni30 wants to merge 1 commit into
Open
#108 Blog owner can now enable or disable comments for blog post#148manojkulkarni30 wants to merge 1 commit into
manojkulkarni30 wants to merge 1 commit into
Conversation
umaslakshmi
reviewed
Aug 25, 2017
| rootNode.Add(new XElement("LastModified", post.LastModified.ToString("o"))); | ||
| rootNode.Add(new XElement("IsPublic", post.IsPublic.ToString())); | ||
| rootNode.Add(new XElement("Excerpt", post.Excerpt)); | ||
| rootNode.Add(new XElement("EnableComments", post.EnableComments)); |
Contributor
There was a problem hiding this comment.
Do you have to convert this to a string first? Like post.EnableComments.ToString()? That is what we were doing for IsPublic, but maybe it's not necessary.
lucasisaza
approved these changes
Aug 25, 2017
lucasisaza
left a comment
lucasisaza
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for helping us out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the functionality to enable or disable comments for blog post.
@julietdaniel , @lucasisaza @umaslakshmi please review the pull request. Let me know if you have any suggestions.