[VEN-3301] Executors guard#2
Open
kkirka wants to merge 11 commits into
Open
Conversation
kkirka
force-pushed
the
feat/executors-guard
branch
from
517d7d9 to
a664ea7
Compare
GitGuru7
reviewed
Jul 3, 2025
| /// @notice Adds multiple executors to the calling Safe's executor list | ||
| /// @param executorsList Array of executor addresses to add | ||
| /// @dev This function can only be called by contracts (Safe wallets) | ||
| function addExecutors(address[] calldata executorsList) external onlyContract { |
There was a problem hiding this comment.
Are there any potential risks if a malicious contract invokes this function?
There was a problem hiding this comment.
I don't see any security issues if it's invoked by an malicious contract. A malicious contract cannot add a executor for a different contract address. It can only add executors for itself.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This guard allows only the authorized executors to execute transactions in a Safe wallet. Signers will be able to add/remove executors with a Safe transaction.