Skip to content

[VPD-984] fix(TokenBuyback): Hashdit findings L02 (gap) and I06 (cap clamp) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fred-venus merged 7 commits into from
May 14, 2026
Merged

[VPD-984] fix(TokenBuyback): Hashdit findings L02 (gap) and I06 (cap clamp) #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e9caae
fix(TokenBuyback): Hashdit findings L02 (gap) and I06 (cap clamp)
Debugger022 May 11, 2026
eb491f6
Merge branch 'develop' into feat/VPD-984
Debugger022 May 13, 2026
849e9ca
chore(deployments): redeploy bscmainnet buybacks
Debugger022 May 13, 2026
ce77641
feat: updating deployment files
Debugger022 May 13, 2026
3e26323
feat: add Certik audit report for token converter Phase 2
Debugger022 May 13, 2026
04064b5
feat: add token converter Phase 2 hashdit audit report
Debugger022 May 14, 2026
fe6fb4f
chore: rename Certik audit report for token converter Phase 2
Debugger022 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added audits/188_tokenConverter_Phase2_hashdit_20260508.pdf
View file
Open in desktop
Binary file not shown.
Binary file added audits/190_tokenConverter_Phase2_certik_20260512.pdf
View file
Open in desktop
Binary file not shown.
5 changes: 4 additions & 1 deletion contracts/ProtocolReserve/TokenBuyback.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ contract TokenBuyback is AccessControlledV8, ReentrancyGuardUpgradeable, ITokenB
uint256 internal constant WINDOW = 24 hours;

/// @dev Gap for future storage variables
uint256[43] private __gap;
uint256[44] private __gap;

/// @notice Emitted when PSR transfers tokens and calls updateAssetsState
event AssetsReceived(address indexed comptroller, address indexed asset, uint256 amount);
Expand Down Expand Up @@ -353,6 +353,9 @@ contract TokenBuyback is AccessControlledV8, ReentrancyGuardUpgradeable, ITokenB
ensureNonzeroValue(newCap);
emit DailyCapUpdated(dailyCapUsd, newCap);
dailyCapUsd = newCap;
if (usdConsumedInWindow > newCap) {
usdConsumedInWindow = newCap;
}
}

/// @notice Updates the absolute USD slippage threshold above which AbnormalSlippage is emitted
Expand Down
60 changes: 30 additions & 30 deletions deployments/bscmainnet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
]
},
"BTCBTreasuryBuyback": {
"address": "0x69739FF52e90BC93dCaEd5a2431072b5082d326D",
"address": "0x1F306a0d929a7098a0A0b12248Ba97600AB79026",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -1006,7 +1006,7 @@
]
},
"BTCBTreasuryBuyback_Implementation": {
"address": "0xa9a0B9d2509EfcB06b8EE3812c8442A32C843e0b",
"address": "0x058a9f1D43580E6d0ABB9103aE2F908327dB723d",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -1830,7 +1830,7 @@
]
},
"BTCBTreasuryBuyback_Proxy": {
"address": "0x69739FF52e90BC93dCaEd5a2431072b5082d326D",
"address": "0x1F306a0d929a7098a0A0b12248Ba97600AB79026",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -3395,7 +3395,7 @@
]
},
"ETHTreasuryBuyback": {
"address": "0x9e0543F9E09fb5b8a58F73d11967DC894dbD40a7",
"address": "0x41954F0bf26959dF2e1B8302DEBf736B5b154B64",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -4324,7 +4324,7 @@
]
},
"ETHTreasuryBuyback_Implementation": {
"address": "0x908c0aFD4a3e73a69fECbc425729ffB319446Ed9",
"address": "0xf125447c4a82421627a5C7Aa03E58029f64585FB",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -5148,7 +5148,7 @@
]
},
"ETHTreasuryBuyback_Proxy": {
"address": "0x9e0543F9E09fb5b8a58F73d11967DC894dbD40a7",
"address": "0x41954F0bf26959dF2e1B8302DEBf736B5b154B64",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -7157,7 +7157,7 @@
]
},
"RiskFundBuyback": {
"address": "0xfffB20c23650B27126815994f3F07eF6B46aea60",
"address": "0x0c71EFabD00329E839745ef23aB946d3ed24A805",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -8086,7 +8086,7 @@
]
},
"RiskFundBuyback_Implementation": {
"address": "0x0175a9888dB6104C9f2c47d87C661e5D6d109FDa",
"address": "0xB842fE2eA255B94FCD091EbadFA7283e37dAa823",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -8910,7 +8910,7 @@
]
},
"RiskFundBuyback_Proxy": {
"address": "0xfffB20c23650B27126815994f3F07eF6B46aea60",
"address": "0x0c71EFabD00329E839745ef23aB946d3ed24A805",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -15384,7 +15384,7 @@
]
},
"UPrimeBuyback": {
"address": "0xFd50bd4107705929df73Ac683BD505232BA9E9dB",
"address": "0xBC9fFBfb799B2d189669D3816E2B7273c69041bd",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -16313,7 +16313,7 @@
]
},
"UPrimeBuyback_Implementation": {
"address": "0xbB3304B6a1eB1d48E1d2EE78eadDadD4024DF358",
"address": "0xf988F3f434aDF5858AFcFCb9B07A5a914c104a63",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -17137,7 +17137,7 @@
]
},
"UPrimeBuyback_Proxy": {
"address": "0xFd50bd4107705929df73Ac683BD505232BA9E9dB",
"address": "0xBC9fFBfb799B2d189669D3816E2B7273c69041bd",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -17347,7 +17347,7 @@
]
},
"USDCTreasuryBuyback": {
"address": "0xFB5FA544dBf39983198BDD01e2c26E3AB597e22A",
"address": "0xd7aC40f9bd9A1beb8E2d121b4446CF90417cf169",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -18276,7 +18276,7 @@
]
},
"USDCTreasuryBuyback_Implementation": {
"address": "0x3be5EfA5F5974dE4491c73Fe1085445b63D5C879",
"address": "0xFd2fe1459088688e271F5867e666a5532115a00D",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -19100,7 +19100,7 @@
]
},
"USDCTreasuryBuyback_Proxy": {
"address": "0xFB5FA544dBf39983198BDD01e2c26E3AB597e22A",
"address": "0xd7aC40f9bd9A1beb8E2d121b4446CF90417cf169",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -19236,7 +19236,7 @@
]
},
"USDTPrimeBuyback": {
"address": "0x0191Bb3CD28A96691F5EC5066ad42A0373ae11C6",
"address": "0xD721932C7CA41Eb5305867287010587a266346a8",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -20165,7 +20165,7 @@
]
},
"USDTPrimeBuyback_Implementation": {
"address": "0x52f4c550a310340284e07B4A8A2722c20C71D39B",
"address": "0x6c0b809EA21E4Bb9799E06c3f9C572671C691a31",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -20989,7 +20989,7 @@
]
},
"USDTPrimeBuyback_Proxy": {
"address": "0x0191Bb3CD28A96691F5EC5066ad42A0373ae11C6",
"address": "0xD721932C7CA41Eb5305867287010587a266346a8",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -21199,7 +21199,7 @@
]
},
"USDTTreasuryBuyback": {
"address": "0xBF858c95D778022b48E6Ad343D3d644017fb0ca7",
"address": "0xB3dDf13E8B6b8dE10F5826087C202b80F1D1b490",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -22128,7 +22128,7 @@
]
},
"USDTTreasuryBuyback_Implementation": {
"address": "0x4d2F53c8549CAa7FbaAFba387B60132cEAd1d2ab",
"address": "0xA9685aFF08b10e7582a91bce703206C67326b235",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -22952,7 +22952,7 @@
]
},
"USDTTreasuryBuyback_Proxy": {
"address": "0xBF858c95D778022b48E6Ad343D3d644017fb0ca7",
"address": "0xB3dDf13E8B6b8dE10F5826087C202b80F1D1b490",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -23088,7 +23088,7 @@
]
},
"UTreasuryBuyback": {
"address": "0xef7cb42a7EBD4b011905D20Fc8038a603c3f22E4",
"address": "0xec63411423D03327De19135446dDdA3055D2feA8",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -24017,7 +24017,7 @@
]
},
"UTreasuryBuyback_Implementation": {
"address": "0x0D26196F7F2a962a9F84A019Bd0FEcaEbcf66BA6",
"address": "0xb46B59D38FC97e05FC25785c1747549199271037",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -24841,7 +24841,7 @@
]
},
"UTreasuryBuyback_Proxy": {
"address": "0xef7cb42a7EBD4b011905D20Fc8038a603c3f22E4",
"address": "0xec63411423D03327De19135446dDdA3055D2feA8",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -25051,7 +25051,7 @@
]
},
"XVSBuyback": {
"address": "0xBaAc819aE93b29fA6512a095CA00255a4F05b027",
"address": "0x637E6246BBb0F9aBae9d764F5e1bB6347f028C12",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -25980,7 +25980,7 @@
]
},
"XVSBuyback_Implementation": {
"address": "0x851581a9616BC85fAC29a7413c229A7b3d3737bE",
"address": "0x916aA4a6F6EC78bB3fDBD905a75df2f716C9Db63",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -26804,7 +26804,7 @@
]
},
"XVSBuyback_Proxy": {
"address": "0xBaAc819aE93b29fA6512a095CA00255a4F05b027",
"address": "0x637E6246BBb0F9aBae9d764F5e1bB6347f028C12",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -26940,7 +26940,7 @@
]
},
"XVSTreasuryBuyback": {
"address": "0x01D0f07D389692D386EB8D09Da3bbCa5C83be551",
"address": "0x6D2d239c16453062cF145A7a5128A6a60710d236",
"abi": [
{
"anonymous": false,
Expand Down Expand Up @@ -27869,7 +27869,7 @@
]
},
"XVSTreasuryBuyback_Implementation": {
"address": "0xf4944F1f9AE704942aD5F74bBa9238ba2813CC2f",
"address": "0xD2C31b6d51AcFE2F003806EBA3F4518263fbfB8A",
"abi": [
{
"inputs": [
Expand Down Expand Up @@ -28693,7 +28693,7 @@
]
},
"XVSTreasuryBuyback_Proxy": {
"address": "0x01D0f07D389692D386EB8D09Da3bbCa5C83be551",
"address": "0x6D2d239c16453062cF145A7a5128A6a60710d236",
"abi": [
{
"inputs": [
Expand Down
Loading
Loading