feat: update withdraw from matured Pendle vault flow#5612
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR replaces the old matured-vault withdrawal path (which called a generic
Confidence Score: 5/5Safe to merge — the change is well-scoped and the non-matured withdrawal path is untouched. The only observations are advisory suggestions on the matured-path contract call. No defects were found on any changed code path. Both the matured and non-matured flows are exercised by the updated tests. The two flagged items are stylistic/advisory, not current misbehaviours. apps/evm/src/clients/api/mutations/useWithdrawAtMaturityFromPendleVault/index.ts — contains the hardcoded Important Files Changed
Reviews (2): Last reviewed commit: "feat: update withdraw from matured Pendl..." | Re-trigger Greptile |
659f9a6 to
849ad6b
Compare
🦋 Changeset detectedLatest commit: 012dae5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
849ad6b to
dbdb61c
Compare
dbdb61c to
012dae5
Compare
|
@greptile |
| makingAmount: BigInt(makingAmount), | ||
| })); | ||
|
|
||
| const formatWithdrawParams = ({ |
There was a problem hiding this comment.
Curious why we moved formatWithdrawParams from its own file into the hook closure here — is it because it no longer has other consumers, or was there a typing reason?
A few concerns with the current shape: it conflicts with our "one export per file" convention, the helpers get re-created on every fn() call, and we lose the standalone unit-testability the original file had.
Happy to discuss if there's context I'm missing 🙏
Jira ticket(s)
VEN-1322
Changes
Do not merge until the Pendle vault has matured and this update has been QA tested.