[VPD-1292] PrimeV2 Sherlock Audit#676
Open
Debugger022 wants to merge 4 commits into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Round the amount-weighted merge timestamp up instead of down so the merged deposit's effective duration rounds down conservatively, removing a directional bias that let users inflate effective stake by adding tiny deposits without advancing the deposit timestamp.
Restores the original advance-baseline behavior in accrueInterest. Rewarding a behavior requires the user to be actively contributing (XVS stake + supported-market position); carrying the slice forward would credit arrival timing rather than participation. The tokens remain in the PrimeLiquidityProvider balance and can be reallocated via sweepToken in a governance VIP if needed. Reverts 61625b1.
When sumOfMembersScore is zero the PLP slice has no recipient and was previously stranded once unreleasedPLPIncome advanced past it. Recording it in undistributedReward and adding an ACM-gated sweepUndistributed lets governance reclaim the funds without touching user-owed balances, addressing Sherlock #10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
accrueInterestnow early-returns whenmarkets[vToken].sumOfMembersScore == 0, leavingunreleasedPLPIncome[underlying]unchanged so the slice carries forward and is distributed once the first user gains a positive score in that market