Skip to content

ci: disable credential persistence in soothfast checkout - #7

Merged
Verdenroz merged 1 commit into
mainfrom
ci/disable-cred-persistence
Sep 7, 2026
Merged

Verdenroz merged 1 commit into
mainfrom
ci/disable-cred-persistence

Conversation

@Verdenroz

@Verdenroz Verdenroz commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Description

The soothfast job's push kept failing with a 403 from github-actions[bot], even though the OIDC broker was minting a valid soothfast-bot token. actions/checkout persists the default GITHUB_TOKEN as a git http.extraheader, and that header wins over the credential helper land.sh sets up for its push, so git kept authenticating as the wrong identity. Setting persist-credentials: false stops checkout from writing that header, leaving the minted bot token as the only credential in play.

Changes

  • Added persist-credentials: false to the soothfast job's checkout step in .github/workflows/ci.yml.

Testing

  • CI-only change, no local test command applies. Verified by inspecting the resulting workflow diff; behavior gets confirmed on the next soothfast job run against this branch.

@Verdenroz
Verdenroz marked this pull request as ready for review September 7, 2026 00:51
@Verdenroz
Verdenroz enabled auto-merge (squash) September 7, 2026 00:52
@soothfast-bot

soothfast-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

soothfast gate

scry-core

gate: measuring merge-base of origin/main in worktree (interleaved rounds)
gate: bench binaries identical (code and data match) — no measurable change possible
gate: gating backend = walltime
gate: build=0f9f00 noise_floor=0.30% thresholds: instructions +5% ir +5% walltime +10.0% alloc/size +5% polls/wakes +5%
ok    scry_core::bench_chunk_rust walltime_median_ns 7051993.0 -> 7051993.0 (+0.0%)
ok    scry_core::bench_chunk_rust allocs 3628 -> 3628 (allowed <= 3809)
ok    scry_core::bench_chunk_rust alloc_bytes 793931 -> 793931 (allowed <= 833627)
ok    scry_core::bench_dense_search walltime_median_ns 7937676.0 -> 7937676.0 (+0.0%)
ok    scry_core::bench_dense_search allocs 11 -> 11 (allowed <= 11)
ok    scry_core::bench_dense_search alloc_bytes 16274 -> 16274 (allowed <= 17087)
ok    scry_core::bench_expand_symbols walltime_median_ns 2537.8 -> 2537.8 (+0.0%)
ok    scry_core::bench_expand_symbols allocs 55 -> 55 (allowed <= 57)
ok    scry_core::bench_expand_symbols alloc_bytes 2366 -> 2366 (allowed <= 2484)
ok    scry_core::bench_hash_bytes walltime_median_ns 75900.7 -> 75900.7 (+0.0%)
ok    scry_core::bench_hash_bytes allocs 0 -> 0 (allowed <= 0)
ok    scry_core::bench_hash_bytes alloc_bytes 0 -> 0 (allowed <= 0)
ok    scry_core::bench_lexical_search walltime_median_ns 16216506.0 -> 16216506.0 (+0.0%)
ok    scry_core::bench_lexical_search allocs 34 -> 34 (allowed <= 35)
ok    scry_core::bench_lexical_search alloc_bytes 2467 -> 2467 (allowed <= 2590)
ok    scry_core::bench_normalize_remote_url walltime_median_ns 224.4 -> 224.4 (+0.0%)
ok    scry_core::bench_normalize_remote_url allocs 5 -> 5 (allowed <= 5)
ok    scry_core::bench_normalize_remote_url alloc_bytes 116 -> 116 (allowed <= 121)
ok    scry_core::bench_search_with_vector walltime_median_ns 37902535.0 -> 37902535.0 (+0.0%)
ok    scry_core::bench_search_with_vector allocs 1286 -> 1286 (allowed <= 1350)
ok    scry_core::bench_search_with_vector alloc_bytes 169014 -> 169014 (allowed <= 177464)
ok    scry_core::bench_chunk_rust assert complexity: claimed O(n); growth drift x1.00 over sizes [64, 256, 1024] (limit x2.5)
ok    scry_core::bench_hash_bytes assert alloc: allocs 0 <= 0
ok    scry_core::bench_hash_bytes assert complexity: claimed O(n); growth drift x0.98 over sizes [4096, 65536, 1048576] (limit x2.5)
ok    scry_core::bench_normalize_remote_url assert alloc: allocs 5 <= 5
gate: passed (7 item(s))

@Verdenroz
Verdenroz merged commit 8b058bc into main Sep 7, 2026
2 checks passed
@Verdenroz
Verdenroz deleted the ci/disable-cred-persistence branch September 7, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant