Repository navigation
Match intrinsic BLS curves and intervals to the fitted model - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intrinsic BLS plots substituted covariate-adjusted means into a sharp spline at a shifted knot, so the displayed mean and pointwise intervals could disagree with the fitted RAM model. In the review fixture at time 6, the old curve showed 47.8 while the model expectation was 49.19999935.
This change retains the expansion knot, adjusted internal means, unadjusted slopes and mean knot deviation, and evaluates the fitted smoothed expression with its full joint covariance. It covers standalone, group, mixture, TVC and multivariate growth components; nonintrinsic spline behavior is preserved. Documentation distinguishes their exact-knot interval behavior.
Regression tests compare curves directly with OpenMx expectations and interval propagation with numerical RAM derivatives, including nonzero covariate means, positive/negative knot shifts, simultaneous slope/knot effects and parent-model covariance. Stored BLS interval tests now use the RAM target. NLS, optimizer/retry controls, model-building equations, numerical references and tolerances are unchanged.
Validation at f6ffd1e:
The archive is 2,244,335 bytes, SHA-256
9d1cedea9de1de9ab18676be5edada3bc7987ad3be15c557c9d99e3c75dfe337. Its source revision and 140 included code/test/help/data files match the candidate. Archive validation, package checks, full fitting, portable checks, documentation.Specified covariance fixtures verify propagation, not empirical nonlinear interval coverage. Existing qualifications for excluded or inadmissible reference fits remain unchanged.
The maintainer will upload the rebuilt v1.0.0 archive to CRAN after validation. This PR does not submit the package or create a release.