Skip to content

Fix code issues related to unused input and output arguments#95

Merged
ehennestad merged 14 commits into
devfrom
codeissues/fix-unused-function-inputs-and-outputs
May 14, 2026
Merged

Fix code issues related to unused input and output arguments#95
ehennestad merged 14 commits into
devfrom
codeissues/fix-unused-function-inputs-and-outputs

Conversation

@ehennestad
Copy link
Copy Markdown
Collaborator

@ehennestad ehennestad commented May 14, 2026

Cleanup of MATLAB Code Analyzer issues reported by codecheckToolbox.

Scope

  • ASGLU (Value assigned but unused) — 62 unused outputs replaced with ~, or the unused outputs dropped entirely where the call permits.
  • Unused function inputssrc/evt style callback arguments replaced with ~.
  • Removed dead codeTaskTable.m deleted; unused jFrame property removed; redundant if/else blocks with identical branches collapsed.
  • Bug fixes surfaced by the analyzer
    • Loop index variable shadowed in a nested function (uifigure_menu_mode_demo.m)
    • Wrong loop index in roiMap
    • Call to non-existent method in OptionsManager
    • Clarified ambiguous logical expression in RoI
    • Horizontal centering bug in a virtual container
  • Compatibility hardening — added error handling around the deprecated JavaFrame property; moved findJavaComponents to a more appropriate location.

No public API changes; behavior preserved except for the explicit bug fixes listed above.

Copy link
Copy Markdown

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Analyzer found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Test Results

199 tests  ±0   199 ✅ ±0   27s ⏱️ +4s
 11 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c064ca2. ± Comparison against base commit ff38dc4.

♻️ This comment has been updated with latest results.

ehennestad and others added 13 commits May 14, 2026 22:42
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Unused class

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…n each block

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace unused output assignments with ~ or reduce requested outputs
across 36 files. Resolves all 62 ASGLU warnings reported by
codecheckToolbox.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@ehennestad ehennestad force-pushed the codeissues/fix-unused-function-inputs-and-outputs branch from 610ce04 to c064ca2 Compare May 14, 2026 20:44
@ehennestad ehennestad merged commit 49c7ab0 into dev May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants