ci: make Validate green (lovelace after_dependency, in-repo brand assets, pinned hassfest/HACS) - #4
Merged
Merged
Conversation
…assets, pin hassfest/hacs
- manifest.json: after_dependencies: ["lovelace"] — dashboard.py imports
homeassistant.components.lovelace lazily and reads hass.data[LOVELACE_DATA];
hassfest DEPENDENCIES check failed on it since July. after_ (not hard)
dependency: the dashboard is optional and degrades to a warning when
lovelace is absent.
- custom_components/veton/brand/{icon,icon@2x,logo,logo@2x}.png rendered
from the vector marks (icon 256/512 square, logo 128/256 short side, all
RGBA transparent, gold #BD9A5F). HACS' brands check accepts in-repo assets
first; home-assistant/brands no longer accepts custom-integration PRs
(Brands Proxy API, HA 2026.3+ serves these files locally).
- validate.yml: pin actions/checkout to the v4.4.0 SHA already used by ci.yml,
home-assistant/actions/hassfest@master and hacs/action@main to today's
commit SHAs (note: hacs/action's docker image tag still floats on :main).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0161NYdEAK1p8DYcnwnnmJdd
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…ue_tracker) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0161NYdEAK1p8DYcnwnnmJdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
validate.ymlhas been red since July on two checks we never fixed:[DEPENDENCIES] Using component lovelace but it's not in 'dependencies' or 'after_dependencies'—dashboard.pylazily importshomeassistant.components.lovelaceand readshass.data[LOVELACE_DATA].brands— the integration is neither inhome-assistant/brandsnor ships its own brand assets.What
manifest.json:"after_dependencies": ["lovelace"](soft: the dashboard is optional and already degrades to a warning when lovelace is not loaded). Keys kept in hassfest sort order.custom_components/veton/brand/{icon,icon@2x,logo,logo@2x}.png— rendered from the vector marks (veton-icon.svg,veton-logo-accent.svg): icon 256²/512², logo short side 128/256, RGBA transparent, brand gold#BD9A5F. HACS checks for in-repobrand/icon.pngfirst; HA 2026.3+ serves these via the Brands Proxy API.home-assistant/brandsno longer accepts custom-integration PRs (see their PR template), so this is the only route — no upstream PR needed.validate.yml: pinnedactions/checkout(v4.4.0 SHA, same asci.yml),home-assistant/actions/hassfest@masterandhacs/action@mainto today's commit SHAs. Caveat:hacs/action'saction.ymlrunsdocker://ghcr.io/hacs/action:main, so the image itself still floats.No
ignore: brandsneeded — the check passes on our own assets.🤖 Generated with Claude Code
https://claude.ai/code/session_0161NYdEAK1p8DYcnwnnmJdd