fix: use distinct scheme_name on APIKeyHeader so Swagger shows correct curl headers (#80)#319
Open
Som23Git wants to merge 1 commit intoVexa-ai:mainfrom
Open
Conversation
…t curl headers - Add scheme_name="AdminApiKey" to API_KEY_HEADER (X-Admin-API-Key) - Add scheme_name="UserApiKey" to USER_API_KEY_HEADER (X-API-Key) - FastAPI collapses both into one scheme when scheme_name is missing, causing Swagger to show X-API-Key for all routes including admin ones - Add regression test (test_openapi_schema.py) that validates both schemes exist in /openapi.json with correct header names Closes Vexa-ai#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief updates:
Manual tests:
Addresses this comment.
Closes #80
And, attaching my virtually consented/signed Individual CLA per CONTRIBUTING.md
individual-cla.pdf