Refactor/solver modularization v1 - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modularize the backend solver architecture and fix cross-year/weekend leave handling so scheduling logic is more maintainable and leave behavior is consistent between backend and frontend.
Changes
backend/app.pyinto a modular solver package:hard,soft,mixed),generate_planning(...)facade behavior in routes.planning_start_date) from route to solver engine.dd-mm-only matching.PlanningTableto resolve day labels fromplanningStartDateand match leave/unavailable/training using full config dates (dd-mm-YYYY).Con..Tests
test_solver_modularization.py).dd-mmmatches but year differs,Con.when weekend dates are inside leave range.python -m pytest -q=>73 passednpm test -- --runInBand=>2 passed suites,7 passed testsWhy
This reduces solver monolith complexity and makes constraints easier to evolve safely, while fixing real leave-date correctness issues (year collisions and weekend rendering) in a way that keeps backend and frontend date semantics aligned.