Repository navigation
fix(network): parse NetherNet addresses at every join entry point - #15
Open
AlexProgrammerDE wants to merge 1 commit into
Open
AlexProgrammerDE wants to merge 1 commit into
AlexProgrammerDE wants to merge 1 commit into
Conversation
Quick Play calls ServerAddress.parseString directly and bypasses the multiplayer screen wrapper. Parse supported NetherNet schemes at that shared entry point so Quick Play, saved-server, and menu joins retain the same socket address. Keep ordinary address parsing and protocol-specific default ports unchanged.
florianreuth
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse supported NetherNet URIs in
ServerAddress.parseString. Quick Play calls this shared parser directly and bypasses the multiplayer screen wrapper.Remove the redundant screen parser. Ordinary addresses retain vanilla parsing and protocol-specific default-port handling.
Validation
./gradlew --no-daemon --console=plain clean check buildpasses.This standalone patch has no test sources.
A fresh Quick Play comparison with this upstream-only JAR remains pending.
Each PR starts from upstream 14f31f4 and contains one independent change.
The build uses upstream ViaBedrock
0.0.31-SNAPSHOT, resolved as20261003.172326-5.No StackAnvil setup patch or local Maven repository enters the build.
The three networking patches touch separate files.
All six application orders pass and produce the same source tree.
Source: owning StackAnvil patch.