Fix #108 - Semantic element interactions#109
Open
Jhoan0714 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Fixes #108 a selector-resolution mismatch in interaction script builders for non-CSS element locators.
Vibium already supports semantic element discovery (
xpath,role,text,label, etc.) and actionability checks follow that model.However, several JS-backed interaction scripts re-resolved elements using CSS-only
querySelector(selector), which fails when semantic/xpath locators are used andselectoris empty.Root Cause
actionability.gouses this branching philosophy:!hasSemantic(ep) && ep.Selector != ""Some interaction builders in
handlers_interaction.godid not mirror that rule and used CSS-only lookup in follow-up JS operations.Changes
clicker/internal/api/handlers_interaction.goscriptConfigbuildScript(...)useCSSInteractionScript(...)This keeps behavior consistent while reducing duplicated script assembly code.
tests/js/async/interaction.test.jsAdded coverage for non-CSS locators:
Input methods
Select
Focus
dispatchEvent
Checkbox
Why this matters
This closes a real gap between element discovery and action execution, making semantic workflows reliable across interaction APIs and preventing regressions with explicit tests.
Validation
Executed: