Regenerate package-lock.json to remove malformed @vibium/* stubs#115
Open
paulsmith wants to merge 1 commit into
Open
Regenerate package-lock.json to remove malformed @vibium/* stubs#115paulsmith wants to merge 1 commit into
paulsmith wants to merge 1 commit into
Conversation
The lockfile contained 5 entries under packages/vibium/node_modules/@vibium/*
with only {"optional": true} — no version, resolved, or integrity. These had
been carried forward across version bumps that hand-edited version strings
instead of running `make set-version`.
On a fresh `npm install`, arborist's dedupe step called semver.gte("") on the
empty version field and crashed with `TypeError: Invalid Version:`, breaking
`make deps` and every target that depends on it.
Regenerated by deleting the file and running `npm install`. The 5 platform
packages now hoist to top-level node_modules/@vibium/* with full
version/resolved/integrity, matching what `make set-version` produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lockfile contained 5 entries under packages/vibium/node_modules/@vibium/* with only {"optional": true} — no version, resolved, or integrity. These had been carried forward across version bumps that hand-edited version strings instead of running
make set-version.On a fresh
npm install, arborist's dedupe step called semver.gte("") on the empty version field and crashed withTypeError: Invalid Version:, breakingmake depsand every target that depends on it.Regenerated by deleting the file and running
npm install. The 5 platform packages now hoist to top-level node_modules/@vibium/* with full version/resolved/integrity, matching whatmake set-versionproduces.Fixes #114