Bind serve to loopback and reject non-local WebSocket origins#177
Open
paulsmith wants to merge 1 commit into
Open
Bind serve to loopback and reject non-local WebSocket origins#177paulsmith wants to merge 1 commit into
paulsmith wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind
vibium serveto loopback by default and reject non-local WebSocket origins.Root Cause
The proxy server printed a
ws://localhost:...endpoint, butclicker/internal/api/server.goactually listened on:port, which exposed the server on every interface. The same server also accepted every WebSocket origin viaCheckOrigin, so any reachable browser page could attach if the port was accessible.What Changed
127.0.0.1Start()through the loopback listen address instead of all interfacesOriginheaders while still allowing clients that send noOriginImpact
This keeps
servealigned with its local-only contract and closes an avoidable remote-control surface for browser automation.Validation
cd clicker && GOCACHE=/private/tmp/vibium-go-build-cache go test ./internal/apiNotes
go test ./...still fails for a pre-existing repository issue:clicker/cmd/clicker/skill.goembeds a missingSKILL.md.