Skip to content

tests: format histogram code labels as quoted integers#132

Open
HNO3Miracle wants to merge 1 commit into
VictoriaMetrics:masterfrom
HNO3Miracle:hno3/fix-histogram-label-format
Open

tests: format histogram code labels as quoted integers#132
HNO3Miracle wants to merge 1 commit into
VictoriaMetrics:masterfrom
HNO3Miracle:hno3/fix-histogram-label-format

Conversation

@HNO3Miracle

Copy link
Copy Markdown

Format the integer status code with %d and add the required Prometheus label quotes explicitly. The current %q directive is invalid for integers and causes current Go vet checks to fail.

Tested with go test ./....

Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant