Vince2007/SevenGuys#13
Open
Jane11eR wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the purpose to document what each class and method does, I added javadocs to help with that so it can be understood well. It can help other people when looking at the code know what the classes and methods do. I added TODO comments as a way to help write a description that can create a better format for your code in your classes. Some of them also help as a reminder to refactor your conditionals in your ExitGame class. Some of the TODO comments also help with you adding arrays to store and use your data since I did not see any being used. For some of the classes under the altscenes subpackage, I deleted unneccesary imports like swing because you are already using javafx so there was no purpose for you to import swing too. I refactored some of the code in the classes like fiveAttackWater because some of your inline comments were not needed and I fixed the spacing what was between that. I thought your code functioned well, but it could use some more edits to become even better!