Peer Review#9
Open
Jeramiahgarza wants to merge 3 commits into
Open
Conversation
Author
|
The 2nd "test" is my actual advice for improvment |
…e respective setOnAction handlers for the buttons. Ensures stats are updated only when the user interacts with the buttons. I Called updateStats() this ensures that the displayed stats (conviction and madness) are updated immediately after a stat is changed. I added Reusable Constants for Styles such as TEXT_STYLE and SMALL_TEXT_STYLE which are defined to handle font size and weight. These can be reused throughout the class to avoid duplication. If styles need to be updated later, you only need to modify these constants. This adds consistency ensuring all text and button styles are consistent, preventing accidental mismatches in font sizes or weights.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My peer review for seven Guys.