Skip to content

fix: restore generated stack checks and browser dependency installation - #79

Merged
VinkyDev merged 3 commits into
mainfrom
fix/generated-unused-subpaths
Nov 12, 2026
Merged

VinkyDev merged 3 commits into
mainfrom
fix/generated-unused-subpaths

Conversation

@VinkyDev

@VinkyDev VinkyDev commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Generated auth and Electron contract packages fail Knip 6.45.1 on unused #src/* imports. Linux verification and Studio also fail before browser tests because Ubuntu's archive domains cannot resolve, including the hosted Azure mirror and archive.ubuntu.com.

 packages/auth/package.json (standard + Effect)
 packages/electron/package.json
-  "imports": { "#src/*": "./src/*" }

 Linux verification + Studio system dependencies
-  hosted Ubuntu archive mirror list
+  shared browser-deps action using mirrors.kernel.org/ubuntu

Keep the desktop app's used alias, shadcn's hook installation target, and every test. Studio installs Chromium separately after system libraries. Apt retains Ubuntu's signing keys and signature verification. Kernel.org is listed on Ubuntu's package download page and operated by the Linux Kernel Archives.

Snapshots and ten golden manifests are synchronized. Manifest changes update fingerprints for every Better Auth or Electron stack, so CI re-verifies affected coverage. Existing Knip validation owns the subpath regression check.

Evidence

  • Before: Both hono-mongodb-better-auth-expo-docker-bun-pm and spa-electron-docker-e2e-bun-pm fail Knip 6.45.1.
    After: Both forced verifications pass, including Expo Android/iOS exports and SPA browser tests.
  • Before: Linux browser prerequisites fail resolving both Azure and official Ubuntu archive domains; changing to archive.ubuntu.com alone did not resolve it.
    After: Direct downloads from mirrors.kernel.org return 200 for all four signed InRelease indexes: noble, noble-updates, noble-backports, noble-security. Updates/security indexes are dated November 11. The 3,513,360-byte fonts-ipafont-gothic package SHA-256 matches Ubuntu's published value. Actual Ubuntu apt execution awaits CI; local host runs TencentOS.
  • vp run ready: passes; 42 test files, 12,881 tests.
  • Independent reviews: 0 Important, 0 Nit.
  • Windows verification passed on rerun (job 130578469560); initial Next.js login test timeouts did not recur.

Merge Danger

Door: two-way

Blast Radius: generation-and-CI

Unused internal aliases are removed from generated manifests. CI browser jobs download Ubuntu packages from Kernel.org; package signature checks, system libraries, and browser tests remain required.

Summary by CodeRabbit

  • Chores
    • Updated Linux CI jobs to install Chromium system dependencies through a shared setup step, using a different Ubuntu package mirror.
    • Adjusted Chromium installation in the Studio job.
    • Removed internal source import aliases from package configuration; existing package exports remain unchanged.
  • Documentation
    • Updated verification guidance to reflect the Linux browser dependency setup and package mirror.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Package contributions no longer add the #src/* import mapping. A shared action configures the Kernel.org Ubuntu mirror and installs Chromium system dependencies for the Linux verification and Studio jobs.

Changes: Package import mappings

Layer / File(s) Summary
Remove package import mappings
packages/integrations/src/better-auth.ts, packages/integrations/src/better-auth/effect.ts, packages/integrations/src/electron.ts
The package contributions no longer add the #src/* import mapping. The auth package’s "." export remains unchanged.

Chromium system dependencies

Layer / File(s) Summary
Share Chromium dependency installation
.github/actions/browser-deps/action.yml, .github/workflows/ci.yml, docs/verification.md
The shared action writes the Kernel.org Ubuntu mirror URL and installs Chromium system dependencies. The Linux verification and Studio jobs use the action, and the documentation describes this setup.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 8931b

This change fixes generated-stack checks and CI browser dependency installation. No concrete merge-blocking risk was identified. CI will confirm the mirror setup on Ubuntu runners.

Pre-merge checks: Passed 7

Check name Status Explanation
Title check Passed The title accurately summarizes the two main changes: restoring generated stack checks and fixing browser dependency installation.
Description check Passed The description includes Summary, Evidence, and Merge Danger sections. It identifies affected packages, CI jobs, test results, verification limits, door type, and blast radius.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Pull Request Template Passed Evidence names the Next.js login test and reports results for vp run ready. Merge Danger states the door is two-way and the blast radius is generation-and-CI.
Cli Contract Alignment Passed The PR does not change any file in apps/cli/src. The CLI contract alignment check does not apply.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between b5e6fca and 8931b57.

Files selected for processing: 2

  • .github/actions/browser-deps/action.yml
  • docs/verification.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@VinkyDev VinkyDev changed the title fix(generator): remove unused auth and Electron subpath imports fix: restore generated stack checks and browser dependency installation Nov 11, 2026
@VinkyDev
VinkyDev merged commit 5675322 into main Nov 12, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant