Skip to content

VP-2399: Apply EventBasedIndexation setting value immediately#91

Open
eMazeika wants to merge 2 commits into
devfrom
dev-VP-2399
Open

VP-2399: Apply EventBasedIndexation setting value immediately#91
eMazeika wants to merge 2 commits into
devfrom
dev-VP-2399

Conversation

@eMazeika
Copy link
Copy Markdown

@vc-ci
Copy link
Copy Markdown
Contributor

vc-ci commented May 19, 2020

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Module.cs#L137: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. rule

akak1977
akak1977 previously approved these changes May 20, 2020
Copy link
Copy Markdown
Contributor

@yecli yecli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eMazeika eMazeika changed the title Apply EventBasedIndexation setting value immediately VP-2399 VP-2399: Apply EventBasedIndexation setting value immediately May 20, 2020
@eMazeika eMazeika requested a review from yecli May 20, 2020 09:15
@lnetrebskii lnetrebskii changed the base branch from dev-3.0.0 to dev May 26, 2020 06:39
@lnetrebskii lnetrebskii dismissed akak1977’s stale review May 26, 2020 06:39

The base branch was changed.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Egidijus Mazeika seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants