VCST-4983: Improve refund flow#494
Merged
Merged
Conversation
fix: OuterId returned from provider is discarded fix: Modification failure wrongly rejects the refund fix: Cancel Document & manual status edit bypass the payment method
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
🧪 Katalon Test Report — ✅ PASSED
📋 Suite details
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f34553c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: OuterId returned from provider is discarded
fix: Modification failure wrongly rejects the refund
fix: Cancel Document & manual status edit bypass the payment method
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4983
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Orders_3.1006.0-pr-494-f345.zip
Note
Medium Risk
Touches payment/refund state transitions and provider-callback persistence, which can affect financial operation workflows if edge cases are missed. Changes are localized but impact critical order/payment documents and UI guardrails.
Overview
Fixes refund/capture provider response handling so a non-empty provider
OuterIdis persisted when saving refund/capture results.Adjusts refund modification flow to preserve the prior refund status when an update call fails (instead of forcing
Rejected), clears reject reason on success, and avoids retriggering provider calls by excludingStatus/OuterIdfrom refund-change detection (trackingIsCancelledinstead). The UI now blocks cancel and manual status edits for refunds that areProcessedor already have anouterId.Updates test tooling by bumping
coverlet.collectorto10.0.0.Reviewed by Cursor Bugbot for commit f34553c. Bugbot is set up for automated code reviews on this repo. Configure here.