VCST-4834: Migrate pricing delete dialogs to platform shared dialog#232
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
vc-ci
reviewed
Mar 26, 2026
Contributor
vc-ci
left a comment
There was a problem hiding this comment.
Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.367
Timestamp: 26-03-2026T16:35:29
Contributor
🧪 Katalon Test Report — ✅ PASSED
📋 Suite details
|
artem-dudarev
approved these changes
Apr 2, 2026
|
basilkot
added a commit
that referenced
this pull request
Apr 15, 2026
…232) # Conflicts: # src/VirtoCommerce.PricingModule.Core/VirtoCommerce.PricingModule.Core.csproj # src/VirtoCommerce.PricingModule.Data.MySql/VirtoCommerce.PricingModule.Data.MySql.csproj # src/VirtoCommerce.PricingModule.Data.PostgreSql/VirtoCommerce.PricingModule.Data.PostgreSql.csproj # src/VirtoCommerce.PricingModule.Data.SqlServer/VirtoCommerce.PricingModule.Data.SqlServer.csproj # src/VirtoCommerce.PricingModule.Data/VirtoCommerce.PricingModule.Data.csproj # src/VirtoCommerce.PricingModule.Web/module.manifest
basilkot
added a commit
that referenced
this pull request
Apr 15, 2026
…232) # Conflicts: # src/VirtoCommerce.PricingModule.Core/VirtoCommerce.PricingModule.Core.csproj # src/VirtoCommerce.PricingModule.Data.MySql/VirtoCommerce.PricingModule.Data.MySql.csproj # src/VirtoCommerce.PricingModule.Data.PostgreSql/VirtoCommerce.PricingModule.Data.PostgreSql.csproj # src/VirtoCommerce.PricingModule.Data.SqlServer/VirtoCommerce.PricingModule.Data.SqlServer.csproj # src/VirtoCommerce.PricingModule.Data/VirtoCommerce.PricingModule.Data.csproj # src/VirtoCommerce.PricingModule.Web/module.manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
deleteAll-dialog.tpl.html(bulk assignment delete) to platform's shared dialog and removed obsolete templateassignments-delete-alllocalization block from all 13 languagespricelist,price,assignmentcount localization keysTest plan
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-4834
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Pricing_3.1001.0-pr-232-bc99.zip
Note
Medium Risk
Moderate risk due to upgrading multiple
VirtoCommerce.Platform.*package references and changing the UI delete-confirmation flow across several blades, which could affect deletion UX/behavior if the shared dialog API differs.Overview
Migrates Pricing module delete confirmations (price lists, price list items, assignments including bulk filtered delete, and item prices) to the platform shared
showDeleteConfirmationDialog, switching dialogs to passitemswith localized count labels.Removes the module-specific bulk delete template (
deleteAll-dialog.tpl.html) and deletes the unusedassignments-delete-alllocalization block across all languages while adding new count keys (assignment,pricelist,price).Bumps the module’s Platform dependencies and manifest
platformVersionfrom3.1002.0to3.1013.0.Written by Cursor Bugbot for commit bc99b00. This will update automatically on new commits. Configure here.