Skip to content

VCST-4834: Migrate pricing delete dialogs to platform shared dialog#232

Merged
basilkot merged 3 commits into
devfrom
fix/VCST-4834
Apr 2, 2026
Merged

VCST-4834: Migrate pricing delete dialogs to platform shared dialog#232
basilkot merged 3 commits into
devfrom
fix/VCST-4834

Conversation

@basilkot
Copy link
Copy Markdown
Contributor

@basilkot basilkot commented Mar 26, 2026

Description

  • Migrated 4 delete flows: price lists, price list items, assignments, and item prices
  • Migrated custom deleteAll-dialog.tpl.html (bulk assignment delete) to platform's shared dialog and removed obsolete template
  • Removed unused assignments-delete-all localization block from all 13 languages
  • Added pricelist, price, assignment count localization keys

Test plan

  • Verify delete dialog for price lists shows count
  • Verify delete dialog for price list items shows count
  • Verify delete dialog for assignments (regular and "delete all filtered") works correctly
  • Verify delete dialog for item prices shows count

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-4834

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Pricing_3.1001.0-pr-232-bc99.zip


Note

Medium Risk
Moderate risk due to upgrading multiple VirtoCommerce.Platform.* package references and changing the UI delete-confirmation flow across several blades, which could affect deletion UX/behavior if the shared dialog API differs.

Overview
Migrates Pricing module delete confirmations (price lists, price list items, assignments including bulk filtered delete, and item prices) to the platform shared showDeleteConfirmationDialog, switching dialogs to pass items with localized count labels.

Removes the module-specific bulk delete template (deleteAll-dialog.tpl.html) and deletes the unused assignments-delete-all localization block across all languages while adding new count keys (assignment, pricelist, price).

Bumps the module’s Platform dependencies and manifest platformVersion from 3.1002.0 to 3.1013.0.

Written by Cursor Bugbot for commit bc99b00. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread src/VirtoCommerce.PricingModule.Web/Scripts/blades/assignment-list.js Outdated
Copy link
Copy Markdown
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.367
Timestamp: 26-03-2026T16:35:29

@vc-ci
Copy link
Copy Markdown
Contributor

vc-ci commented Apr 1, 2026

🧪 Katalon Test Report — ✅ PASSED

🔢 Total ✅ Passed ❌ Failed
13 13 0
📋 Suite details
Suite Test Suites/Modules/module_Assets
Failures 0
Errors 0
Timestamp 02-04-2026T15:41:49

🔗 View run · Commit: c240c9c

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

@basilkot basilkot merged commit ba65354 into dev Apr 2, 2026
9 checks passed
@basilkot basilkot deleted the fix/VCST-4834 branch April 2, 2026 15:48
basilkot added a commit that referenced this pull request Apr 15, 2026
…232)

# Conflicts:
#	src/VirtoCommerce.PricingModule.Core/VirtoCommerce.PricingModule.Core.csproj
#	src/VirtoCommerce.PricingModule.Data.MySql/VirtoCommerce.PricingModule.Data.MySql.csproj
#	src/VirtoCommerce.PricingModule.Data.PostgreSql/VirtoCommerce.PricingModule.Data.PostgreSql.csproj
#	src/VirtoCommerce.PricingModule.Data.SqlServer/VirtoCommerce.PricingModule.Data.SqlServer.csproj
#	src/VirtoCommerce.PricingModule.Data/VirtoCommerce.PricingModule.Data.csproj
#	src/VirtoCommerce.PricingModule.Web/module.manifest
basilkot added a commit that referenced this pull request Apr 15, 2026
…232)

# Conflicts:
#	src/VirtoCommerce.PricingModule.Core/VirtoCommerce.PricingModule.Core.csproj
#	src/VirtoCommerce.PricingModule.Data.MySql/VirtoCommerce.PricingModule.Data.MySql.csproj
#	src/VirtoCommerce.PricingModule.Data.PostgreSql/VirtoCommerce.PricingModule.Data.PostgreSql.csproj
#	src/VirtoCommerce.PricingModule.Data.SqlServer/VirtoCommerce.PricingModule.Data.SqlServer.csproj
#	src/VirtoCommerce.PricingModule.Data/VirtoCommerce.PricingModule.Data.csproj
#	src/VirtoCommerce.PricingModule.Web/module.manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants