Remove "hero" DIV Class and UI Change to Nav Dropdown#1505
Merged
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
FrancisTRAlt
changed the title
meg-gutshall
requested changes
May 22, 2026
Contributor
meg-gutshall
left a comment
meg-gutshall
left a comment
There was a problem hiding this comment.
Can you add one thing? When the dropdown is expanded, please have it collapse when the user clicks outside of the dropdown menu. After that, it will be ready to merge! Looks great so far!
Contributor
Author
|
@meg-gutshall It is now implemented. Let me know if anything else! |
JoeKarow
requested changes
May 26, 2026
Member
JoeKarow
left a comment
JoeKarow
left a comment
There was a problem hiding this comment.
The build is failing due to some typescript errors. These three changes should resolve them.
Co-authored-by: Joe Karow <58997957+JoeKarow@users.noreply.github.com>
Co-authored-by: Joe Karow <58997957+JoeKarow@users.noreply.github.com>
Co-authored-by: Joe Karow <58997957+JoeKarow@users.noreply.github.com>
meg-gutshall
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Description
Remove the "hero" DIV element to fix the drop down z-index issue. This is the result shown below:
Additionally, remove the style inline code for visibility. Initially, the text is dark. Now the background of the drop down is white by default:
Methodology
There was an unnecessary div element that breaks the z-index's drop down visibility. Removed it without changing the order of the z-index. Additionally, on smaller screens, the text is hard to see when enabling the drop down. Remove the inline style for visibility.
Code of Conduct