Showcase: correct PipTrade skill terminal claim, document the quote and safety APIs - #108
Showcase: correct PipTrade skill terminal claim, document the quote and safety APIs#108codedforum wants to merge 2 commits into
Conversation
…nd safety APIs The skill said the /rh terminal runs limit, TWAP and stop orders. The live page says the Pro terminal is being rebuilt, so a buyer agent would have promised a user orders that hit a coming-soon screen. Corrected to market orders today. It also listed POST /api/quote without field names, units, response shape or error codes, and never said how to obtain the GO CAUTION BLOCK verdict it referenced throughout, so neither was callable. Both are now documented from the live service: - a dry quote needs no session, so any agent can price a route - amount is in base units, the most common integration error - full request, response and error taxonomy - GET /api/rh/sellcheck as the public safety gate, and the chain parameter whose absence returns a false CAUTION and a wrong decimals value - scripts/pip-quote.mjs, a runnable read-only end-to-end example Frontmatter moved version under metadata to match the Agent Skills spec. Every documented claim verified against the live service.
|
This is a fantastic update, thanks so much for circling back to correct the stale claim about the terminal's order types. That kind of diligence is hugely appreciated. The new documentation for the quote and safety APIs is super clear and the runnable example is a great addition. Especially appreciate you calling out the common traps like the Looks great, no notes from me. Refreshed after a new push. Any inline suggestions from the first pass may now be stale. |
Per review, showcase packages stay markdown-only. The runnable example now lives on a domain the builder controls and the skill links to it: https://piptradedex.xyz/agent/pip-quote.mjs The parts worth reading are still inline in the skill: the base-units conversion and the error branching. Only the runnable file moved out.
|
Thanks, and happy to move it. Done in cdfe8cc. The runnable example now lives at https://piptradedex.xyz/agent/pip-quote.mjs and the skill links to it. The net diff on this PR is a single markdown file again. Nothing of value was lost: the two things worth reading were always the exact base-units conversion and the error branching, and both are still inline in the SKILL.md. Only the runnable file moved out. One note in case it is useful for the rubric rather than for this PR. A few showcase packages already carry executable code, including some inside Happy to move |
Follow-up to #70, correcting one claim that went stale and filling two gaps that made the skill hard for another agent to actually use.
The terminal claim was wrong
The skill told buyer agents twice that the
/rhterminal runs "market, limit, TWAP, or stop order, run by a keeper". The live page now says the Pro terminal is being rebuilt and those order types are coming back. An agent reading the merged skill would have promised a user a TWAP order that lands on a coming-soon screen. Corrected to market orders today, with the rest described as returning.The terminal was rebuilt after the original PR was written, which is how it slipped through.
The quote API was listed but not callable
POST /api/quoteappeared with no field names, units, response shape or error codes. Now documented from the live service:amountis in base units, which is the most likely integration error and fails as an unhelpfulbusyminobject onamount_rangeGETon aPOSTroute returns the landing page HTML at 200, so agents are told to branch onok, never the statusThe safety verdict had no documented source
The skill referenced GO / CAUTION / BLOCK throughout but never said how to obtain one. Added both surfaces: the public
GET /api/rh/sellcheckand the session-gatedPOST /api/app2/safety, with the mapping into a single verdict and the rule that absence of evidence is CAUTION, never GO.Worth flagging for other builders: omitting the
chainparameter on the sell check runs it as a Robinhood Chain simulation, so a healthy Base token returnssellable: null, "unverifiable", a false CAUTION, and the same response carries a wrongdecimals. That is now documented and handled.Also
scripts/pip-quote.mjs, a runnable read-only example doing the whole flow: resolve assetIds, exact base-units conversion, sell check, quote. No auth, no signing.versionmoved undermetadatato match the Agent Skills spec, which allows onlyname,description,license,compatibility,metadataandallowed-tools.Verification
node scripts/validate-showcase.mjspasses. Every documented claim was tested against the live service, including both 401s, the POST-route HTML behaviour,missing_fields, assetId and decimals resolution, the worked example returning every documented field anonymously, and the base-units trap failing as described.