Remove UdonToolkit dependency; upgrade CI/CD and VPM environment; add udonsharp-lint CI by Copilot · Pull Request #14 · VirtualAviationJapan/Virtual-CNS

Copilot · 2026-04-07T09:20:18Z

Previous session changes (ATCRadar count field, dead OnAfterEditor removal, package-lock.json sync)
ATCRadar.cs: Fix warning condition; RadioTunerDemultiplexer.cs: guard empty tuners in Start(); StandbyFrequencySwitcher.cs: add _RequestSerialization alias; inject attribute cleanups; CDIAnimationDriver.cs rename typo
RadioTunerDemultiplexer.cs: Guard Index setter against empty tuners; guard toggledObjects bounds; remove unused using TMPro;
ATCRadar.cs: Initialize previousPositions[i] and previousTimes[i] in Start()
StandbyFrequencySwitcher.cs: Remove unused using TMPro; and using URC;
ATCRadar.cs: Use Time.time - Mathf.Epsilon for previousTimes[i]; RadioTunerDemultiplexer.cs: clamp Index against Mathf.Min(tuners.Length, standbyTuners.Length)
USharpInjectAttribute.cs, UdonSharpComponentInjectAttribute.cs, ComponentInjectAttribute.cs: Fix array injection to use Array.CreateInstance(valueType, count) instead of GetConstructor(...).Invoke(...); RadioTunerDemultiplexer.cs: null-guard SelectedTuner/StandbyTuner and make all callers no-op when tuner is null
udonsharp-lint CI: Added .config/dotnet-tools.json pinning tktco.UdonSharpLinter v0.3.1 and .github/workflows/udonsharp-lint.yml running the linter over Packages/ on every push and pull request touching C# files — all 44 scripts currently pass with 0 errors/warnings

…tic-release v25, Actions v4) Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/9778e518-40c7-4f63-a428-b099814794b8 Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

…sory Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/9778e518-40c7-4f63-a428-b099814794b8 Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/73a8b469-24ba-4df9-b970-c79f60988a6b Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Copilot

Pull request overview

This PR removes the UdonToolkit dependency from the Virtual-CNS packages and upgrades the repository’s CI/release tooling and VPM/Unity/VRChat SDK package environment to current versions.

Changes:

Removed sh.orels.udontoolkit from package dependencies and stripped UdonToolkit-only attributes/usings from affected UdonSharp scripts.
Upgraded VPM/Unity targeting across packages (Unity 2019.4 → 2022.3, VRChat Worlds 3.1.1 → 3.10.2, removed explicit com.vrchat.udonsharp).
Updated GitHub Actions and semantic-release toolchain to newer major versions.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Packages/jp.virtualaviation.virtual-flight-data-bus/package.json	Removes UdonToolkit dep; bumps Unity/VRChat VPM versions; drops explicit UdonSharp VPM dep.
Packages/jp.virtualaviation.virtual-flight-data-bus.connector-sf/package.json	Bumps Unity/VRChat VPM versions; drops explicit UdonSharp VPM dep.
Packages/jp.virtualaviation.virtual-cns/package.json	Removes UdonToolkit dep; bumps Unity/VRChat VPM versions; drops explicit UdonSharp VPM dep.
Packages/jp.virtualaviation.virtual-cns/RadioTuner/Scripts/StandbyFrequencySwitcher.cs	Removes UdonToolkit editor hook attribute usage.
Packages/jp.virtualaviation.virtual-cns/RadioTuner/Scripts/RadioTunerDemultiplexer.cs	Removes UdonToolkit attributes (`ListView`, editor hook).
Packages/jp.virtualaviation.virtual-cns/RadioTuner/Scripts/RadioTuner.cs	Removes UdonToolkit attributes; replaces inspector buttons with `ContextMenu`.
Packages/jp.virtualaviation.virtual-cns/RadioTuner/Scripts/AudioSelector.cs	Removes UdonToolkit editor hook attribute usage.
Packages/jp.virtualaviation.virtual-cns/Navigation/Scripts/MarkerReceiver.cs	Removes UdonToolkit attributes (`Popup`, `MaterialOf`).
Packages/jp.virtualaviation.virtual-cns/Navigation/Scripts/MarkerBeacon.cs	Removes UdonToolkit `using`.
Packages/jp.virtualaviation.virtual-cns/Instruments/Scripts/CDIAnimationDriver.cs	Removes UdonToolkit `Popup` attributes.
Packages/jp.virtualaviation.virtual-cns/General/Scripts/USharpInjectAttribute.cs	Removes UdonToolkit dependency from inject attribute base.
Packages/jp.virtualaviation.virtual-cns/General/Scripts/Attirubtes/UdonSharpComponentInjectAttribute.cs	Removes UdonToolkit dependency from inject attribute base.
Packages/jp.virtualaviation.virtual-cns/General/Scripts/Attirubtes/ComponentInjectAttribute.cs	Removes UdonToolkit dependency from inject attribute base.
Packages/jp.virtualaviation.virtual-cns/Communication/Scripts/AirbandDatabase.cs	Removes UdonToolkit `ListView` attributes.
Packages/jp.virtualaviation.virtual-cns/ATIS/Scripts/ATISGenerator.cs	Removes UdonToolkit `ListView`/`Popup` attributes.
Packages/jp.virtualaviation.virtual-cns/AirTrafficControl/Scripts/ATCRadar.cs	Removes UdonToolkit attributes; replaces editor button with `ContextMenu`.
package.json	Upgrades semantic-release and plugin majors; drops explicit UdonSharp VPM dep.
.github/workflows/release.yml	Upgrades `actions/checkout` and `actions/setup-node` to v4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

esnya · 2026-04-07T09:31:38Z

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/c970cec7-4c15-46a9-9ac3-d7b912ec478c Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

esnya · 2026-04-08T07:24:38Z

@copilot apply changes based on the comments in this thread

…terEditor blocks, sync package-lock.json Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/832adf64-b4a3-4e4f-aa8c-5ae96403282b Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Copilot · 2026-04-08T07:32:04Z

@copilot apply changes based on the comments in this thread

Done in commit 9c816b7:

ATCRadar.cs: Replaced System.Array.Resize with a cached count private field set in Start(). Update() now returns early when count == 0 and computes Time.frameCount % count — original serialized arrays are never mutated at runtime.
StandbyFrequencySwitcher.cs, AudioSelector.cs, RadioTunerDemultiplexer.cs: Removed all dead OnAfterEditor / SetupHelperGUI methods and their now-unused #if UNITY_EDITOR conditional imports.
package-lock.json: Removed the stale sh.orels.udontoolkit entries for both virtual-cns and virtual-flight-data-bus packages.

Copilot

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

esnya · 2026-04-08T07:46:29Z

@copilot apply changes based on the comments in this thread

esnya · 2026-04-09T09:14:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65ac3dc114

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

esnya · 2026-04-09T09:24:45Z

@codex review

esnya · 2026-04-09T09:39:57Z

@codex review

chatgpt-codex-connector · 2026-04-09T09:46:40Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

esnya · 2026-04-09T10:08:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9f88cacd93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T11:21:43Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector · 2026-04-09T11:23:26Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3b87ce28a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T11:26:56Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector · 2026-04-09T11:34:05Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector · 2026-04-09T11:36:35Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c35a100dee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-09T22:06:21Z

+    TARGET_COMMIT='HEAD'
+    mapfile -t CHECK_FILES < <(git diff-tree --no-commit-id --name-only --root -r "$TARGET_COMMIT" -- "${CHECK_PATHS[@]}")
+    if [ "${#CHECK_FILES[@]}" -gt 0 ]; then
+      git diff-tree --check --no-commit-id --root -r "$TARGET_COMMIT" -- "${CHECK_FILES[@]}"


Check whitespace across pushed commit range

In CI pushes where GITHUB_BASE_REF is unset, this fallback sets TARGET_COMMIT='HEAD' (and the sibling branch uses HEAD^2) and then calls git diff-tree --check for that single commit only. Per git diff-tree -h (<tree-ish> [<tree-ish>]), the one-argument form validates one commit, not the full pushed range, so a multi-commit push can still pass even if an earlier commit introduced trailing whitespace. Please diff/check against the push range (for example, before..after or merge-base...HEAD) so all pushed changes are covered.

Useful? React with 👍 / 👎.

Copilot AI and others added 3 commits April 7, 2026 08:37

chore: upgrade to latest environment (SDK 3.10.2, Unity 2022.3, seman…

a3cda17

…tic-release v25, Actions v4) Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/9778e518-40c7-4f63-a428-b099814794b8 Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

revert: revert com.unity.textmeshpro version bump due to malware advi…

20ca0c5

…sory Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/9778e518-40c7-4f63-a428-b099814794b8 Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

feat: remove UdonToolkit dependency from all scripts and package.json

6f7eb63

Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/73a8b469-24ba-4df9-b970-c79f60988a6b Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Copilot AI assigned Copilot and esnya Apr 7, 2026

Copilot created this pull request from a session on behalf of esnya April 7, 2026 09:20 View session

esnya marked this pull request as ready for review April 7, 2026 09:24

esnya requested a review from Copilot April 7, 2026 09:25

Copilot started reviewing on behalf of esnya April 7, 2026 09:25 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Comment thread Packages/jp.virtualaviation.virtual-cns/AirTrafficControl/Scripts/ATCRadar.cs Outdated

Copilot started work on behalf of esnya April 7, 2026 09:31 View session

esnya changed the base branch from master to alpha April 7, 2026 09:35

Changes before error encountered

316b656

Agent-Logs-Url: https://github.com/VirtualAviationJapan/Virtual-CNS/sessions/c970cec7-4c15-46a9-9ac3-d7b912ec478c Co-authored-by: esnya <2088693+esnya@users.noreply.github.com>

Copilot AI requested a review from esnya April 7, 2026 09:39

Copilot started work on behalf of esnya April 7, 2026 09:50 View session

Copilot finished work on behalf of esnya April 7, 2026 09:56

esnya requested a review from Copilot April 7, 2026 10:52

Copilot started reviewing on behalf of esnya April 7, 2026 10:53 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

Copilot started work on behalf of esnya April 8, 2026 07:24 View session

Copilot finished work on behalf of esnya April 8, 2026 07:34

esnya requested a review from Copilot April 8, 2026 07:39

Copilot started reviewing on behalf of esnya April 8, 2026 07:40 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

fix: keep ATIS playback alive on empty runway config

65ac3dc

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread .releaserc.yml

chore: allow release config on main too

2b991ec

fix: guard ATIS playback against empty clip lists

24d5f82

ci: add reusable static and UdonSharp checks

9f88cac

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread scripts/run-static-checks.sh Outdated

esnya added 5 commits April 9, 2026 19:45

fix: skip empty ATIS tokens during encoding

151d61d

fix: make static checks validate committed changes

f9f35d6

fix: scope static whitespace checks to head commit

d3b87ce

fix: limit static whitespace checks to code and config diffs

5dd2f63

fix: harden static checks on CI merge commits

1dbb760

fix: scope CI static checks to checked commits

755905c

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread scripts/run-static-checks.sh Outdated

fix: check only changed files in CI static checks

2be5356

chore: harden checks and follow alpha dependencies

f581a4e

fix: validate static checks against PR range

9358a04

esnya added 3 commits April 10, 2026 05:29

fix: declare connector sf flight dependency

b1fb181

fix: normalize virtual cns package dependency contracts

8162e05

fix: restore virtual-cns release config and presets

c35a100

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Uh oh!

Conversation

Copilot AI commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

esnya commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

esnya commented Apr 8, 2026

Uh oh!

Copilot AI commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

esnya commented Apr 8, 2026

Uh oh!

esnya commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

esnya commented Apr 9, 2026

Uh oh!

esnya commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

esnya commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 9, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 9, 2026

Choose a reason for hiding this comment

Copilot AI commented Apr 7, 2026 •

edited

Loading