Ch 210312 raytrace mc #213
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unit tests to check writing. Currently code is reading and writing to a local folder. Need to change that in the future.
…se to use the constructs already in place for reading PhotonDatabase. Reading appears to be working. Writing is a problem because the header is not written which has different format than ZRDRayDataPoint. Unit tests pass right now.
…onstructs like ZRDDatabaseWriterController, ZRDRayDataPointSerializer, DatabaseWriterFactory, DatabaseExtensionMethods and modified MonteCarloSimulation to use these new constructs to write a ZRDRayDataPoint to a binary file with the appropriate header so that Zemax can import it. Wrote associated unit tests.
… code to recognize it and run it.
…t, also wrote segment number to match output. Removed commented out code.
# Conflicts: # src/Vts.Desktop.Test/Vts.Desktop.Test.csproj # src/Vts.Desktop/Vts.Desktop.csproj # src/Vts.sln # src/Vts/MonteCarlo/MonteCarloSimulation.cs
# Conflicts: # src/Vts.Desktop.Test/Vts.Desktop.Test.csproj # src/Vts.Desktop/Vts.Desktop.csproj # src/Vts/Vts.csproj
…was without folder is now in folder.
…ts below. # Conflicts: # src/Vts/MonteCarlo/Types/TallyType.cs # src/Vts/Vts.csproj
…vate and creating a property that encapsulates it.
# Conflicts: # src/Vts/MonteCarlo/Types/DatabaseType.cs
…t Position, Direction and Weight (may not use these Vts classes in future). Move all Zemax related code to "Zemax" folder. Applications that do the translation to/from ZRD file to MCCL ray database may still need Vts.dll. Everything compiles but many unit tests failing.
… database infile. Need LM to review Vts.sln in this commit.
…oject. Moved prior unit tests that tested ZRD files, ZRDRayDatabaseTests, to Test project. Now all tests pass except for those in Vts.MonteCarlo.ZemaxDatabaseConverter.Test. Cleaned up RayDatabaseTests, tests that check if reading/writing to MCCL database works.
…r app. All unit tests in solution currently passing.
…er Program tests sometimes pass, sometimes fail, 2) straggler testraydatabase, testraydatabase.txt not cleaned up but can't tell which test is leaving them, 3) I would like to test reading in actual Zemax ZRD file, however one I have is 389KB and not sure I should put in resources.
…VS and in BuildTestRelease.ps1.
…, changed to "var" in locations, "readonly" and "static" additions, method rename from DPBelongsToSurfaceVirtualBoundary to DpBelongsToSurfaceBounday, comment spelling corrections.
…xDatabaseConverter progam and modified unit test accordingly.
…and cleaned up code unique to branch. # Conflicts: src/Vts/MonteCarlo/Factories/DatabaseWriterFactory.cs
…ts solely in some csproj files related to updated NuGet packages.
…cts: # src/Vts/MonteCarlo/MonteCarloSimulation.cs
…cts in src/Vts.sln regarding VS version and Benchmark using Release not Debug.
…ts in: src/Vts/MonteCarlo/DataStructures/SimulationInputProvider.cs, src/Vts/MonteCarlo/Factories/DetectorControllerFactory.cs, src/Vts/MonteCarlo/Factories/VirtualBoundaryFactory.cs and src/Vts/MonteCarlo/MonteCarloSimulation.cs
…in SimulationInputProvider.cs and cleaned up and added code so that dbWriter and enumerator closed so that test cleanup doesn't think file is still open.
…ts in: # src/Vts.sln
…ts in: # src/Vts/MonteCarlo/DataStructures/SimulationInputProvider.cs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't plan to push this branch to master. I created PR so that I could see code changes I made.