fix: email notification sending#412
Open
CodeVoyager wants to merge 1 commit into
Open
Conversation
CodeVoyager
force-pushed
the
fix/email-service
branch
from
f6c49f9 to
f37163b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 96.02% 98.00% +1.98%
==========================================
Files 39 40 +1
Lines 1081 1104 +23
Branches 260 263 +3
==========================================
+ Hits 1038 1082 +44
+ Misses 42 21 -21
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add a new email service to handle email sending with timeout management. - Refactor existing email sending logic in client service to utilize the new email service. - Ensure proper error handling and logging for email operations. - Update common service to parse IDs correctly.
CodeVoyager
force-pushed
the
fix/email-service
branch
from
f37163b to
7420d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
#404
Summary
Safety checks for e-mail notification sending.
Test Plan
How are you testing the work you're submitting?