Codex exec delegation scaffolding#1
Merged
Conversation
Makes the Claude->codex-exec contract executable: - .codex/DELEGATION.md (canonical in-repo contract; --json typo fixed) - .codex/schemas/codex-result.schema.json (--output-schema target) - .codex/task-template.md (task packet format) - AGENTS.md (Codex-facing worker rules; Codex reads AGENTS.md, our conventions were CLAUDE.md-only) - scripts/codex-run.sh (dispatch + run-packet capture, defensive about unverified -o/model assumptions; CODEX_MODEL env) - CLAUDE.md division-of-labor section (Codex is the code workhorse; Claude keeps architecture/taste/integration/judgment and owns runtime/visual inspection directly via the harness + chrome-devtools MCP, not delegated) - .gitignore .codex-runs/; settings allowlist for the helper + codex exec, deny sandbox/network bypass Director corrections to the source contract: fixed the Explorer command typo, added the missing AGENTS.md, and overrode runtime/UI inspection to Claude-owned per direction.
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2da1220ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Addresses Codex review P2: a missing/unreadable task-file or failed copy previously fell through (no set -e) to a stale task.md from an earlier run with the same run-id. Now requires the source readable and the copy to succeed, else exits non-zero.
Owner
Author
|
P2 addressed in 745e139: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Claude→
codex execdelegation contract executable in-repo.What
.codex/DELEGATION.md— canonical in-repo contract (source--jsontypo corrected).codex/schemas/codex-result.schema.json—--output-schematarget.codex/task-template.md— task-packet formatAGENTS.md— Codex-facing worker rules (Codex readsAGENTS.md; our conventions wereCLAUDE.md-only — real gap)scripts/codex-run.sh— dispatch + full run-packet capture; defensive about the unverified-o/model assumptions;CODEX_MODELenvCLAUDE.md— division-of-labor section: Codex is the code workhorse; Claude keeps architecture/taste/integration/final judgment and owns runtime/visual inspection directly (harness + chrome-devtools MCP), not delegated.gitignore.codex-runs/; settings allowlist for the helper +codex exec, deny sandbox/network bypassDirector corrections to the source contract
--jso--sandbox→--json --sandbox.AGENTS.md(Task Packet referenced it but it didn't exist).modelid and-o+--jsoninteraction; helper is defensive + a one-time smoke check is required before trusting them.Notes
Fixes <ID>yet).@codex reviewbefore merge. CIverifywill run on this PR.