codex-run.sh: close stdin for codex exec (VOI-36)#5
Merged
Conversation
Fixes VOI-36. The prompt is passed as an argument; without </dev/null a backgrounded codex exec prints 'Reading additional input from stdin...' and blocks for an EOF that never arrives (observed hanging ~16min with zero events on the VOI-31 worker run). Redirect stdin from /dev/null. Evidence: bash -n clean; explorer smoke re-run completed exit=0 with 4151 bytes of streamed events (no hang).
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VOI-36.
Problem
scripts/codex-run.shpasses the prompt as an argument but didn't redirect stdin. Backgroundedcodex execthen printsReading additional input from stdin...and blocks for an EOF that never comes — observed hanging ~16 min with zero streamed events during the VOI-31 worker run. Blocks all worker delegation.Fix
Add
< /dev/nullto the invocation.Evidence
bash -n scripts/codex-run.shclean