Add secret_input — a masking text input for API keys#2
Merged
Conversation
text_input / search_field render content in clear; API-key and secret fields need masking. secret_input is text_input with TextEdit::password set — same bordered look, same stable-id rule. The shared bordered_input gains a `mask` flag; the two existing public inputs are unaffected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kakarot-dev
added a commit
that referenced
this pull request
May 22, 2026
text_input / search_field render content in clear; API-key and secret fields need masking. secret_input is text_input with TextEdit::password set — same bordered look, same stable-id rule. The shared bordered_input gains a `mask` flag; the two existing public inputs are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
secret_input— a bordered single-line input that masks its content (renders dots), for API keys and secrets.Why
text_input/search_fieldrender content in clear. The Tokito Settings dialog (VtronTokito/tokito#26) has API-key, Firecrawl-key, Nexar-secret and JWT fields that must be masked — matching the app's pre-migration behaviour. Per thetokito_ui-only rule, the masked variant belongs here.The shared private
bordered_inputgains amaskflag;text_inputandsearch_fieldare unaffected (their public signatures don't change).Verified
cargo clippy --lib --all-features— clean🤖 Generated with Claude Code