move from current and next term to all active terms

[miretskydatwit]

Closes #369

[jaspermayone]

@miretskydatwit pls convert back from draft when you've tested :)

Thx!

[jaspermayone]

Two issues worth fixing before this merges:

1. N+1 query in scope :active

active_terms = all.select do |term|
  reg_start = term.registration_start  # fires a SQL query per term
  ...
end

all.select loads every term into Ruby, then registration_start fires a separate UniversityCalendarEvent query for each one. With 10 terms that's 11 queries; it'll only get worse over time.

Options:

• Preload with includes(:university_calendar_events) before the .select (Term would need a has_many :university_calendar_events)
• Or rewrite as a single SQL subquery — something like where("start_date <= ? AND end_date >= ?", today, today).where("id IN (SELECT term_id FROM university_calendar_events WHERE category = 'registration' AND ...)")

The Ruby-level filtering approach is fine for small datasets in tests, but will hurt in prod.

---

2. Fragile %registration%open% ILIKE filter in registration_start

.where("summary ILIKE ?", "%registration%open%")

This requires the summary to contain both "registration" and "open" in that order. Real university calendar events could say "Open Registration", "Registration Begins", "Registration Period", "Priority Registration", etc. — all of which would be silently missed, causing the fallback to start_date instead of the actual registration open date.

Suggest either:

• Relaxing the filter to just %registration% (the scope already filters to category: 'registration', so the summary filter may not be needed at all)
• Or checking against actual event summaries in production data before locking in this pattern

[jaspermayone]

@miretskydatwit plz address above feedback before marking as ready :)

[jaspermayone]

weird that went twice lol

[miretskydatwit]

@jaspermayone (preferably before you review this PR again) pls review and merge #439 and after merging that, pls merge from main into this branch (fix/369/terms). Thanks!

[miretskydatwit]

@jaspermayone bump, pls review, thx! i do see rspec is failing but not entirely sure why.

[jaspermayone]

This should kind of get solved with the rewrite, but I'll check in on it