feat: passing loading attribute on images without auth token data#305
Open
scottydev wants to merge 1 commit intoWPMedia:arc-themes-release-version-4.0.0from
Open
feat: passing loading attribute on images without auth token data#305scottydev wants to merge 1 commit intoWPMedia:arc-themes-release-version-4.0.0from
scottydev wants to merge 1 commit intoWPMedia:arc-themes-release-version-4.0.0from
Conversation
scottydev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to run
npm test,npm run lint, and write detailed test steps before requesting reviewersDescription
Adding the
loadingattribute on images that don't have a Resizer auth token.Test Steps
Add detailed test steps a reviewer must complete to test this PR
git checkout img-loading-attr-no-authnpm i