fix: return 404 in changeOrder when entry doesn't exist#174
Open
jakebromberg wants to merge 2 commits intomainfrom
Open
fix: return 404 in changeOrder when entry doesn't exist#174jakebromberg wants to merge 2 commits intomainfrom
jakebromberg wants to merge 2 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
fix/16-changeorder-null-check
branch
from
3561cd6 to
c26329a
Compare
jakebromberg
force-pushed
the
fix/16-changeorder-null-check
branch
from
583e0e4 to
c9fb2ac
Compare
2 tasks
Accessing [0].play_order on an empty result crashed with TypeError. Now throws WxycError(404) for a clean error response. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/16-changeorder-null-check
branch
from
c9fb2ac to
73fa156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changeOrdercrashed withTypeError: Cannot read properties of undefined (reading 'play_order')when called with a non-existententry_id, because the query result was accessed at[0]without checking for an empty array.WxycError(404)for a clean error response.Test plan
flowsheet.changeOrder.test.ts— mocksdb.transactionwith a trx returning empty array, assertsWxycErrorwithstatusCode: 404Made with Cursor