test: remove obsolete RTK Query API tests#142
Closed
jakebromberg wants to merge 2 commits intomainfrom
Closed
Conversation
Deploying wxyc-dj with
|
| Latest commit: |
f285947
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d43ad09f.dj-site.pages.dev |
| Branch Preview URL: | https://fix-remove-obsolete-api-test-8grx.dj-site.pages.dev |
2 tasks
jakebromberg
force-pushed
the
fix/remove-obsolete-api-tests
branch
2 times, most recently
from
cacc67d to
0ef255f
Compare
Delete tests for adminApi, authenticationApi, and djRegistryApi which no longer exist. Authentication is now handled by Better Auth instead of RTK Query. Co-authored-by: Cursor <cursoragent@cursor.com>
…rization.ADMIN The Authorization enum only defines NO, DJ, MD, SM -- there is no ADMIN member. The RequireAdmin convenience component was referencing Authorization.ADMIN, causing a TypeScript build failure on Cloudflare Pages. Removed RequireAdmin and its test since admin/owner roles map to SM in mapRoleToAuthorization.
jakebromberg
force-pushed
the
fix/remove-obsolete-api-tests
branch
from
0ef255f to
f285947
Compare
Member
Author
|
Closing — the AuthorizedView changes are already on main. The only remaining diff is accidentally committed artifacts (.env.local.bak, conversation.txt, playwright-report/, test-results/, e2e/.auth/). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #243
Summary
Delete tests for
adminApi,authenticationApi, anddjRegistryApiwhich no longer exist. Authentication is now handled by Better Auth
instead of RTK Query.
Files removed
lib/__tests__/features/admin/api.test.tslib/__tests__/features/authentication/api.test.tsTest plan
Made with Cursor