fix: scope roster table E2E locator to form#268
Closed
jakebromberg wants to merge 0 commit intomainfrom
Closed
Conversation
Deploying wxyc-dj with
|
| Latest commit: |
ea0cebf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6d1046e6.dj-site.pages.dev |
| Branch Preview URL: | https://fix-e2e-roster-table-locator.dj-site.pages.dev |
jakebromberg
force-pushed
the
fix/e2e-roster-table-locator
branch
from
4f99423 to
ea0cebf
Compare
jakebromberg
force-pushed
the
fix/e2e-roster-table-locator
branch
from
ea0cebf to
f5f6db1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rosterTablelocator frompage.locator("table")topage.locator("form table")to avoid Playwright strict mode violation when multiple tables exist in the dashboard layouttableRowstoform tbody trCloses #267
Test plan
admin-email-changetests pass without strict mode violationadmin-roster-management,admin-roster-permissions) still pass