Redirect incomplete users to onboarding#274
Merged
jakebromberg merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
Deploying wxyc-dj with
|
| Latest commit: |
6b0efd2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1fc2ed0.dj-site.pages.dev |
| Branch Preview URL: | https://feat-onboarding-incomplete-r.dj-site.pages.dev |
6 tasks
jakebromberg
added a commit
that referenced
this pull request
Mar 9, 2026
jakebromberg
added a commit
that referenced
this pull request
Mar 9, 2026
jakebromberg
force-pushed
the
feat/onboarding-incomplete-redirect
branch
from
e2ddb9e to
6b0efd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #271 (fix/e2e-test-infrastructure). Adds redirect logic so that users with incomplete profiles (missing
realName) are sent to the onboarding form instead of the dashboard.app/login/@modern/layout.tsx): Verified but incomplete users now see the onboarding form (isIncomplete={true}) instead of being redirected to the dashboard.requireAuth()(lib/features/authentication/server-utils.ts): Dashboard pages redirect incomplete users back to/login?incomplete=true. Uses an"in"check so the redirect only fires when better-auth actually includesrealNamein the session object.e2e/pages/onboarding.page.ts):isOnOnboardingPage()now recognizes/login?incomplete=trueas an onboarding page.Test plan
requireAuth()incomplete user redirect and therealName-not-in-session bypassserver-utils.test.tstests pass (npm run test:run)