Send explicit entry_type for talksets and breakpoints#284
Merged
jakebromberg merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
Deploying wxyc-dj with
|
| Latest commit: |
1a719e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://611a3314.dj-site.pages.dev |
| Branch Preview URL: | https://fix-explicit-entry-type.dj-site.pages.dev |
jakebromberg
force-pushed
the
fix/explicit-entry-type
branch
3 times, most recently
from
4b18b4d to
205f233
Compare
jakebromberg
force-pushed
the
fix/explicit-entry-type
branch
2 times, most recently
from
ac90a67 to
1033090
Compare
Use the FlowsheetEntryType const from @wxyc/shared/dtos instead of relying on the backend to infer entry type from message content. Both modern (TalksetButton, BreakpointButton) and classic (Main.tsx) experiences now send entry_type explicitly in the POST body.
jakebromberg
force-pushed
the
fix/explicit-entry-type
branch
from
1033090 to
1a719e1
Compare
JacksonMeade
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entry_typefield (typed asFlowsheetEntryTypefrom@wxyc/shared/dtos) to the message variant ofFlowsheetSubmissionParamsFlowsheetEntryType.talksetandFlowsheetEntryType.breakpointconsts from@wxyc/shared/dtosin both modern (TalksetButton, BreakpointButton) and classic (Main.tsx) experiencesDepends on: PR #291 (CI fix)
Corresponds to backend change: WXYC/Backend-Service#239
API spec change: WXYC/wxyc-shared#24
Closes #283
Test plan
tsc --noEmitpassesentry_type: "talkset"entry_type: "breakpoint"entry_type: "talkset"entry_type: "breakpoint"