Change use of /dev/mem to /dev/gpiomem#25
Open
MikeDK wants to merge 8 commits intoWallaceIT:masterfrom
Open
Conversation
…rks, and we also do not need root access anymore because /dev/gpiomem access is permitted to group gpio members
Contributor
Author
|
added another commit which removes the unnecessary build configs and .h files ... there is now only one "raspberrypi" build target |
|
This is not universally supported, not all host boards have a gpiomem driver. So at the very least this change should be optional behind a flag, not changed outright. |
Contributor
Author
|
Ok you're right ... I will add a flag to the raspberrypi.h file and restore the stuff to the a10 and am335x |
Contributor
Author
|
done adding a flag for /dev/gpiomem usage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use /dev/gpiomem instead of /dev/mem, we have some benefits...:
Compiling for all build configs, but I have only tested the raspberrypi4 one