V_delta: revert property-block renames for element, daqreader_ndr, daqmetadatareader#53
Merged
Merged
Conversation
…qmetadatareader The renames introduced no advantage over the V_alpha/v1-body field names, and forced every consumer of these property blocks to either rename on read or migrate through the V_delta migrators. Customer code (ndi.element, ndi.daq.reader.mfdaq.ndr, ndi.daq.metadatareader) had always read the v1 body names directly; the rename only created gate-flip surface area. Reverts in V_delta schemas: element.element_name -> element.name element.element_type -> element.type daqreader_ndr.file_type -> daqreader_ndr.ndr_reader_string daqmetadatareader.reader_class -> daqmetadatareader.ndi_daqmetadatareader_class Also restores daqreader_ndr.ndi_daqreader_ndr_class which the original V_delta schema had dropped; the field is still written by NDI-matlab and is needed for reconstruction (ndi.database.fun.ndi_document2ndi_object). The companion did-matlab change deletes the three migrators (element.m, daqreader_ndr.m, daqmetadatareader.m), since v1 bodies now satisfy the V_delta schema unchanged. The companion ndi-matlab change drops the now-unneeded ndi.compat.fieldAliases row for daqmetadatareader.reader_class and the daqreader_ndr reconstruction override in ndi_document2ndi_object. The daqmetadatareader conversion doc is removed (no transformation to document); the _index.md row is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The V_delta schemas renamed three property-block fields that have no advantage over the v1 names and that every NDI-matlab consumer reads in their v1 form. After the [did2 #3] gate flip on NDI-matlab PR #803, those renames surfaced as 44 CI failures with no upside. Reverting V_delta to match the v1 body names eliminates the entire compat layer for these blocks.
Reverts in V_delta schemas:
element.element_namenameelement.nameelement.element_typetypeelement.typedaqreader_ndr.file_typendr_reader_stringdaqreader_ndr.ndr_reader_stringdaqmetadatareader.reader_classndi_daqmetadatareader_classdaqmetadatareader.ndi_daqmetadatareader_classAlso restores
daqreader_ndr.ndi_daqreader_ndr_class(the original V_delta schema had dropped it; the v1 body still writes it and NDI-matlab'sndi.database.fun.ndi_document2ndi_objectreconstructs from it).The
element_epochrestructuring (parallelepoch_clock+t0_t1→clocksarray-of-records) is kept — that one is a real structural improvement, and only a single NDI-matlab reader site cares.Companion PRs
claude/revert-property-block-renames— deletes the three migrator files (element.m,daqreader_ndr.m,daqmetadatareader.m) and updatestests/+did2/+unittest/testMigrators.m. Also fixes a real bug inuniversalRenames.normaliseSuperclasses(stripped v1definitionfield, which broke the validator atdid.database/validate_doc_vs_schema:1238).claude/776-flip-did2-normalize-gate(PR #803) — adapts the onendi.element/loadaddedepochs:408site to readelement_epoch.clocks, drops the now-deaddaqmetadatareader.reader_classalias row and thedaqreader_ndrreconstruction override.Test plan
Generated by Claude Code
Generated by Claude Code