Skip to content

# Refactor: Improve Types of changes detection with case-insensitive check #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wangggym merged 5 commits into from
Jan 26, 2026
Merged

# Refactor: Improve Types of changes detection with case-insensitive check #51

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0fd854
# Summary
Wangggym Jan 26, 2026
708eb01
update
Wangggym Jan 26, 2026
f4a3b52
# Refactor: Fix PR title extraction and optimize body generation
Wangggym Jan 26, 2026
8594d62
Merge master: Resolve conflicts in pr_create.go
Wangggym Jan 26, 2026
c4be07a
# Refactor: Improve Types of changes detection with case-insensitive …
Wangggym Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions go-version/cmd/qkflow/commands/pr_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,21 @@ func runPRCreate(cmd *cobra.Command, args []string) {
lines := strings.Split(strings.TrimSpace(prDesc), "\n")
var titleText string

// 查找 "## Summary" 后面的内容，或者使用第一行
// 查找 "## Summary" 后面的第一个非空行
for i, line := range lines {
line = strings.TrimSpace(line)
if strings.HasPrefix(line, "## Summary") && i+1 < len(lines) {
// 使用 Summary 后面的第一行
titleText = strings.TrimSpace(lines[i+1])
break
if strings.HasPrefix(line, "## Summary") {
// 跳过 Summary 行和后续的空行，找到第一个非空行
for j := i + 1; j < len(lines); j++ {
nextLine := strings.TrimSpace(lines[j])
if nextLine != "" && !strings.HasPrefix(nextLine, "#") {
titleText = nextLine
break
}
}
if titleText != "" {
break
}
} else if !strings.HasPrefix(line, "#") && line != "" && titleText == "" {
// 使用第一个非标题行
titleText = line
Expand Down Expand Up @@ -468,7 +476,13 @@ func buildPRBody(types []string, jiraTicket string, prDesc string) string {

body.WriteString("# PR Ready\n\n")

if len(types) > 0 {
// 检查 prDesc 中是否已经包含 "Types of changes" 部分（不区分大小写）
prDescLower := strings.ToLower(prDesc)
hasTypesInDesc := strings.Contains(prDescLower, "types of changes") ||
strings.Contains(prDescLower, "## types of changes")

if len(types) > 0 && !hasTypesInDesc {
// prDesc 中没有 Types of changes，自动添加
body.WriteString("## Types of changes\n\n")
for _, t := range types {
body.WriteString(fmt.Sprintf("- [x] %s\n", t))
Expand Down
Loading