feat(frontend): ✨ add hidden back-link to URL source - #224
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 6c9b67d
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “hidden” backlink in the About Me hero text by generating a shareable URL (removing customizationPanelShown and the hash, and normalizing localhost to the public origin) and wiring it into the hero component/template.
Changes:
- Introduces
HeroHiddenLinkServiceto derive a cleaned, shareable URL fromdocument.locationwith a router-based fallback. - Adds unit tests covering query param removal, hash stripping, localhost origin replacement, and fallbacks.
- Wires the generated URL into
HeroContentComponentand inserts an anchor into the hero summary text.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/feature/about-me/src/lib/hero-content/hero-hidden-link.service.ts | New service to compute the cleaned “hidden link” URL, including localhost → public origin normalization. |
| libs/feature/about-me/src/lib/hero-content/hero-hidden-link.service.spec.ts | Unit tests validating URL cleanup and fallback behavior. |
| libs/feature/about-me/src/lib/hero-content/hero-content.component.ts | Injects the new service and exposes hiddenLinkUrl() to the template. |
| libs/feature/about-me/src/lib/hero-content/hero-content.component.html | Adds the hidden backlink anchor into the hero summary text. |
Suppressed comments (1)
libs/feature/about-me/src/lib/hero-content/hero-content.component.html:35
- The link is intended to be “hidden”, but there are no styles for
.hidden-linkin this component (and no.hidden-linkstyles found elsewhere), so the comma will likely render with default link styling and will be keyboard-focusable. Consider adding explicit styling (e.g., inherit color, remove underline) and ensuring focus visibility, or using a shared visually-hidden pattern if it should not be perceivable.
25 years of experience in software development<a
class="hidden-link"
target="_blank"
[href]="hiddenLinkUrl()"
>,</a
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fixed AI feedback: The hidden back-link uses target="_blank" but does not set rel="noopener noreferrer", which allows reverse-tabnabbing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.