feat(frontend): ✨ add customizable project item state persistence in URL - #225
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 723bbb2
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds URL-backed persistence for per-project “top project” and “compact” customizations, so UI state can survive refresh/navigation and be shareable via query params.
Changes:
- Replace local per-component signals with a shared URL-backed state service for project item customizations.
- Introduce
CustomizableProjectItemUrlServiceto parse/serialize per-project customizations into a singlecustomProjItemsquery param and keep it synced on navigation. - Extend unit tests for both the component integration and the new URL service behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libs/feature/project-list/src/lib/customizable-project-item.component.ts | Switches customization storage from local signals to URL-backed service reads/writes. |
| libs/feature/project-list/src/lib/customizable-project-item.component.spec.ts | Updates tests to mock the URL service and verify forwarding/reset behavior keyed by project id. |
| libs/feature/project-list/src/lib/customizable-project-item-url.service.ts | New service implementing query param parse/serialize and router-navigation sync for customizations. |
| libs/feature/project-list/src/lib/customizable-project-item-url.service.spec.ts | Adds coverage for parsing, serialization, merging, null-removal, stable ordering, and navigation sync. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.