feat(frontend): ✨ add customizable color chip list state persistence in URL - #226
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit fd2fb1a
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces URL-based persistence for CustomizableColorChipListComponent state (rows + spacing) so that user customizations survive reloads and can be shared via links across the portfolio frontend.
Changes:
- Added
CustomizableColorChipListUrlServiceto aggregate per-chip-list customization into a single URL query param and sync it with navigation. - Updated
CustomizableColorChipListComponentto read/write customization state via the URL service (and require aurlPersistenceKeyinput). - Wired
urlPersistenceKeyinto skill and project list UIs, and updated unit tests / Storybook setup to provide the new dependencies.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/feature/skill-section/src/lib/skill-section.component.ts | Adds URL persistence key sanitization helper for skill categories. |
| libs/feature/skill-section/src/lib/skill-section.component.html | Supplies urlPersistenceKey to chip lists in the skill section. |
| libs/feature/skill-section/src/lib/skill-section.component.spec.ts | Adds required URL-related test providers/mocks. |
| libs/feature/project-list/src/lib/project-item.component.html | Supplies urlPersistenceKey for project technologies chip list. |
| libs/feature/project-list/src/lib/project-item.component.spec.ts | Adds required URL-related test providers/mocks. |
| libs/feature/project-list/src/lib/customizable-project-item.component.spec.ts | Adds required URL-related test providers/mocks. |
| libs/feature/project-list/src/lib/project-item.component.stories.ts | Adds required URL-related Storybook providers/mocks. |
| libs/feature/customizable-color-chip-list/src/lib/customizable-color-chip-list.component.ts | Moves customization state to URL-backed persistence via the new service; adds required key input. |
| libs/feature/customizable-color-chip-list/src/lib/customizable-color-chip-list.component.spec.ts | Expands tests for URL persistence behavior and sets the required key input. |
| libs/feature/customizable-color-chip-list/src/lib/customizable-color-chip-list.component.stories.ts | Adds Storybook wiring for urlPersistenceKey and mocks the URL service. |
| libs/feature/customizable-color-chip-list/src/lib/customizable-color-chip-list-url.service.ts | New URL aggregation/sync service for chip list customization. |
| libs/feature/customizable-color-chip-list/src/lib/customizable-color-chip-list-url.service.spec.ts | New unit tests validating parsing/serialization and sync behavior. |
| libs/feature/customizable-color-chip-list/src/index.ts | Exports the new URL service from the library entrypoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.