refactor(frontend): ♻️ upgrade to typescript 5.8.3 - #228
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Toolchain upgrades can have broad impact, and the lockfile shows Nx ESLint pulling a separate TypeScript 5.7.x version, which may cause inconsistent runtime behavior across tooling.
Pull request overview
This PR upgrades the workspace TypeScript version to ~5.8.3 as a prerequisite for adopting @aws/nx-plugin, updating both the manifest and lockfile to reflect the new compiler version.
Changes:
- Bump
typescriptfrom~5.7.2to~5.8.3inpackage.json. - Update
package-lock.jsonto locktypescript@5.8.3at the workspace root (and reflect the resulting dependency graph).
File summaries
| File | Description |
|---|---|
| package.json | Updates the workspace TypeScript devDependency to ~5.8.3. |
| package-lock.json | Regenerates lock entries to reflect the new root TypeScript version and resulting nested deps. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
104
to
108
| "ts-node": "10.9.1", | ||
| "tslib": "^2.3.0", | ||
| "typescript": "~5.7.2", | ||
| "typescript": "~5.8.3", | ||
| "typescript-eslint": "^8.19.0", | ||
| "vis-network": "^10.0.1", |
|
View your CI Pipeline Execution ↗ for commit 9e573b7
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
- it's a necessary prerequisite for `@aws/nx-plugin` - also upgrade related libraries for compatibility - currently installed angular isn't compatible with a later typescript version - an upgrade of angular might be advisable
Waog
force-pushed
the
update-typescript-version
branch
from
August 30, 2026 15:03
9048066 to
9e573b7
Compare
Waog
changed the title
~5.8.35.8.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@aws/nx-plugin