Cubql auto upload array - #16
Open
Waqar-ukaea wants to merge 22 commits into
Open
Conversation
…witch to cuda path
…t changes from main
…hway a little slow
…ndling is performed at intersection time Also had to change the create_global_*_trees stubs for cuBQL to return a warning rather than fatal_error Cross check verified to produce consistent results across all three ray tracers
…he vk_device probe
…ners for omp offload
Waqar-ukaea
force-pushed
the
cuBQL
branch
2 times, most recently
from
June 18, 2026 13:35
26f4570 to
59d99f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This internal PR is for introducing a version of DPRT's
AutoUploadArraywhich is an RAII container for handling data which needs to be copied from host to device withomp_target. The obious benefits being:omp_target_alloc()andomp_target_memcpy()omp_target_free()as part of its destructor to avoid requiring explicit lifetime managementI'm not certain how I feel about this as an addition just yet. Whilst it does cleanup some of the repeated code it almost feels too complicated for our usecase in XDG. In some ways I kind of prefer the more explicit
omp_targetcalls. I will have a think about whether or not I want to make use of these and keep this PR open as a reminder. They may actually become more useful later on as I make a start on implementing a two-level traversal scheme.