fix: model-turn dummy insert after rollback strip + remote-compaction unsupported hint - #7
Merged
Merged
Conversation
…ort remote-compaction unsupported - --fix-model-turn now locates the last effective message after stripping thread_rolled_back events, instead of using the raw JSONL tail, so it appends the dummy user message when the effective history ends with an assistant/model turn even if an unfinished or rolled-back turn left a trailing user message. - Diagnose Codex remote-compaction-v2 failures and print a user-friendly hint (disable remote compaction or switch provider/model). - Add --disable-remote-compaction flag (backup + config.toml write, requires user approval and --apply). - Add regression tests.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复
--fix-model-turn现在基于移除thread_rolled_back后的 effective 历史定位最后一条消息，而不是用原始 JSONL 末尾；修复了末尾有未完成/回滚 turn 的 user 消息、但有效历史以 assistant 结尾时跳过 dummy insert 的问题。remote compaction v2 expected exactly one compaction output item），报告打印友好提示：关闭远程压缩或切换支持远程压缩的供应商/模型后重试并重启 Codex。--disable-remote-compaction（需--apply和用户同意），写入remote_compaction_v2 = false到 config.toml 的[features]，带备份。